Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes plantuml diagram doesn't export to PDF #67

Closed
leandro-costa opened this issue Nov 18, 2019 · 3 comments
Closed

Sometimes plantuml diagram doesn't export to PDF #67

leandro-costa opened this issue Nov 18, 2019 · 3 comments

Comments

@leandro-costa
Copy link

I did some tests with the file and the diagram did not export to PDF.

I changed "page.setContent" for "page.goto" to a temporary file on "puppeteer.ts" and it worked

commit

@qjebbs
Copy link
Owner

qjebbs commented Nov 18, 2019

Cannot reproduce, I test with the same file you provided, and it exported OK.

Use a tmp file will increase unnecessary disk writing, that is what I always try to avoid.

@leandro-costa
Copy link
Author

leandro-costa commented Nov 18, 2019

Can you test with This file and :

{"plantuml.server": "https://www.plantuml.com/plantuml"}

?

And don't run Markdown Extended in debug mode. Debug delay makes export work. run with extension downloaded from vscode marketplace.

I think is samething like this with object tag

@qjebbs
Copy link
Owner

qjebbs commented Nov 18, 2019

Puppeteer waits until the network request is idle, but the PLantUML renders diagram with object tag, which is not count as a request of current document, I guess. I'll revert this commit: qjebbs/vscode-plantuml@7d85485 later.

No change is required with this extension.

@qjebbs qjebbs closed this as completed Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants