Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes in title are not cleaned from filename on export #17

Closed
ChristophLindemann opened this issue Mar 23, 2017 · 1 comment
Closed

Comments

@ChristophLindemann
Copy link

When you specify a title with quotes ("), the export "succeeds" with no file being created.

I have not tested with other special path characters, although question mark (?) is filtered correctly.

Operating System: Windows 7 Enterprise

Example

@startuml

title "Some Title"

@enduml

Actual Result

No error, but no file.

image

When using Process Monitor you can see the failure:

10:41:58,3135011    Code.exe    13536   CreateFile              E:\diagrams                     SUCCESS
10:41:58,3135434    Code.exe    13536   QueryAllInformationFile E:\diagrams                     BUFFER OVERFLOW
10:41:58,3135712    Code.exe    13536   QueryInformationVolume  E:\diagrams                     BUFFER OVERFLOW
10:41:58,3135922    Code.exe    13536   CloseFile               E:\diagrams                     SUCCESS
10:41:58,3246091    Code.exe    13536   CreateFile              E:\diagrams\ Some Title".png    NAME INVALID

Expected Result

A file called E:\diagrams\Some Title.png

@qjebbs
Copy link
Owner

qjebbs commented Mar 24, 2017

Confirmed. I will repair this in next release. Thank you!

@qjebbs qjebbs closed this as completed in 559a800 Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants