Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar Language Identifier is diagram instead of plantuml #306

Closed
andrewthauer opened this issue Apr 14, 2020 · 1 comment
Closed

Grammar Language Identifier is diagram instead of plantuml #306

andrewthauer opened this issue Apr 14, 2020 · 1 comment

Comments

@andrewthauer
Copy link
Contributor

The language grammar for this extension is defined using a very generic identifier diagram. This seems ambiguous and not specific enough. This seems to be defined:

// line 55 in package.json
"grammars": [
      {
        "language": "diagram", // should be 'plantuml'??
        "scopeName": "source.wsd",
        "path": "./syntaxes/diagram.tmLanguage"
      },
}

Shouldn't the grammar language identifier be named plantuml instead? The term diagram seems to generic and not specific. In the Change Language Mode command it makes no mentioned to plantuml only diagram.

@fuhrmanator
Copy link
Contributor

I agree - I was looking for PlantUML in the language of my new editor, but couldn't figure how to set it. I think many people will look for PlantUML rather than "Diagram".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants