Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] I2C refactor broke Georgi #24112

Closed
2 tasks
EtaoinWu opened this issue Jul 13, 2024 · 0 comments · Fixed by #24113
Closed
2 tasks

[Bug] I2C refactor broke Georgi #24112

EtaoinWu opened this issue Jul 13, 2024 · 0 comments · Fixed by #24113

Comments

@EtaoinWu
Copy link
Contributor

Describe the Bug

Georgi is a split ergo steno keyboard. I was recently hacking it when I discovered that master branch qmk doesn't work on it anymore. The symptom is that compiling and flashing is successful, but no keyboard nor serial output is observed. This happened on current master (5a5f680) but not on the keyboard author's fork, commit 56ea98a.

I did a git bisect and apparently commit e9bd7d7 from earlier this year (which refactored the I2C driver API) broke the support. Since Georgi's microcontroller talks to its other split half using i2c, it is also affected. I checked the code, but apparently it just rewrites old-style manual i2c function calls with newer ones, so I don't understand what could break here.

I got nothing from qmk console but I'm not sure if it's a configuration issue from me (i'm not familiar with qmk).

Keyboard Used

gboards/georgi

Link to product page (if applicable)

not sold anymore

Operating System

Windows 11 22H2 (build 22621.3672)

qmk doctor Output

The following is `qmk doctor` from the first bad commit, e9bd7d7ad3.

Ψ QMK Doctor is checking your environment.
Ψ CLI version: 1.1.5
Ψ QMK home: C:/Users/etaoin/Desktop/qmk_firmware
Ψ Detected Windows 10 (10.0.22621).
Ψ Userspace enabled: False
Ψ Git branch: HEAD
Ψ Repo version: 0.23.5
Ψ - Latest HEAD: 2024-01-17 07:05:38 -0600 (e9bd7d7ad3) -- I2C driver cleanup (#21273)
Ψ - Latest upstream/master: 2024-07-12 22:11:00 -0400 (7b5d7907df) -- adds veilid SAO macropad (#23868)
Ψ - Latest upstream/develop: 2024-07-13 02:11:31 +0000 (5c43a9bed1) -- Merge remote-tracking branch 'origin/master' into develop
Ψ - Common ancestor with upstream/master: 2024-01-17 07:05:38 -0600 (e9bd7d7ad3) -- I2C driver cleanup (#21273)
Ψ - Common ancestor with upstream/develop: 2024-01-17 07:05:38 -0600 (e9bd7d7ad3) -- I2C driver cleanup (#21273)
Ψ All dependencies are installed.
Ψ Found arm-none-eabi-gcc version 13.3.0
Ψ Found avr-gcc version 14.1.0
⚠ We do not recommend avr-gcc newer than 8. Downgrading to 8.x is recommended.
Ψ Found avrdude version 7.3-2024041
Ψ Found dfu-programmer version 1.1.0
Ψ Found dfu-util version 0.11
Ψ Submodules are up to date.
Ψ Submodule status:
Ψ - lib/chibios: 2023-04-15 13:48:04 +0000 --  (11edb1610)
Ψ - lib/chibios-contrib: 2023-11-27 18:15:44 +0100 --  (9d7a7f90)
Ψ - lib/googletest: 2021-06-11 06:37:43 -0700 --  (e2239ee6)
Ψ - lib/lufa: 2022-08-26 12:09:55 +1000 --  (549b97320)
Ψ - lib/vusb: 2022-06-13 09:18:17 +1000 --  (819dbc1)
Ψ - lib/printf: 2022-06-29 23:59:58 +0300 --  (c2e3b4e)
Ψ - lib/pico-sdk: 2023-02-12 20:19:37 +0100 --  (a3398d8)
Ψ - lib/lvgl: 2022-04-11 04:44:53 -0600 --  (e19410f8)
Ψ QMK is ready to go, but minor problems were found

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

n/a

Additional Context

Georgi is sadly not sold anymore, and its maintainer Jane doesn't seem to be active in the keyboard and steno community for 3+ years. All changes since late 2020 on Georgi's code is by the QMK's maintainer team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant