Quotas Bar Charts Incorrect #110

clawrie · 2015-02-17T03:25:22Z

Bars for disk quotas in System Information are not accurate.
Please refer to attached image.

iliajie · 2015-02-17T07:43:20Z

Thanks for reporting.
Help me out to solve this. I need to see the array, that is transformed to those wrong % numbers.

Just do the following:

Open authentic-theme/authentic-lib.cgi (it's in Webmin directory, usually /usr/libexec/webmin).
Find foreach my $t ( @{ $info->{'chart'} } ) { (about the line 296)
Right under this line, hit enter to start a new line and add this prt($t);
Save the file and go to browser.
Click View Frame source, while right clicking with your mouse on right frame on the theme (where quotas are) (In case you're using Firefox, you can find this (View Frame Source) under drop down)
Open source of sysinfo.cgi page and click refresh (CTRL+R or F5)
Then find printed VAR1.

I need that content that will contain numbers about the charts. Please send it to me and I will provide fix as soon as possible.

clawrie · 2015-02-17T07:59:21Z

I'll try to do this tonight for you .. at college until 9PM :(

On Tue, Feb 17, 2015 at 6:13 PM, Ilia Rostovtsev [email protected]
wrote:

Thanks for reporting.
Help me out to solve this. I need to see that array that is transformed to
that numbers.

Just do the following:

Open authentic-theme/authentic-lib.cgi (it's in Webmin directory,
usually /usr/libexec/webmin).

Find foreach my $t ( @{ $info->{'chart'} } ) { (about the line 296)

Right under this line, hit enter to start a new line and add this
prt($t);

Save the file and go to browser.

Click View Frame source, while right clicking with your mouse on right
frame on the theme (where quotas are) (In case you're using Firefox,
you can find this (View Frame Source) under drop down)

Open source of sysinfo.cgi page and click refresh (CTRL+R or F5)

Then find printed VAR1.

I need that content that will contain numbers about the charts. Please
send it to me and I will provide fix as soon as possible.

—
Reply to this email directly or view it on GitHub
#110 (comment)
.

iliajie · 2015-02-17T08:53:16Z

I see. Alright!

iliajie · 2015-02-18T06:38:50Z

You might need to install CPAN module Data::Dumper by going to Webmin->Other->Perl Modules

iliajie · 2015-02-18T18:53:43Z

So can you help me out? Quotas doesn't work on my system for some reasons.. If you don't want to install anything there is another way..

clawrie · 2015-02-18T20:17:35Z

I'll be able to do this today on our teat server.
On 19/02/2015 5:23 am, "Ilia Rostovtsev" [email protected] wrote:

So can you help me out? Quotas doesn't work on my system for some
reasons.. If you don't want to install anything there is another way..

—
Reply to this email directly or view it on GitHub
#110 (comment)
.

clawrie · 2015-02-18T20:18:13Z

Test server that is :(
On 19/02/2015 6:47 am, "Craig Lawrie" [email protected] wrote:

I'll be able to do this today on our teat server.
On 19/02/2015 5:23 am, "Ilia Rostovtsev" [email protected] wrote:

So can you help me out? Quotas doesn't work on my system for some
reasons.. If you don't want to install anything there is another way..

—
Reply to this email directly or view it on GitHub
#110 (comment)
.

iliajie · 2015-02-18T22:16:51Z

Any server where quotas are working. If you do it on different machine, please attach a screenshot again. It should only take few minutes really.

clawrie · 2015-02-19T03:06:53Z

Hi

Here is the info... (the test server only has two sites so only two sets of
data - hope that's enough).

$VAR1 = { 'chart' => [ '1073741824', 110587904, 10125312 ],

$VAR1 = { 'chart' => [ '1073741824', 409600, 8192 ],

[image: Inline image 1]

I can create a webmin user account for you if you would like to take a look
and experiment.
The server is pretty slow though - just a 'tiny' Amazon web server instance
for testing things out.

Craig

On Thu, Feb 19, 2015 at 8:46 AM, Ilia Rostovtsev [email protected]
wrote:

Any server where quotas are working. If you do it on different machine,
please attach a screenshot again. It should only take few minutes really.

—
Reply to this email directly or view it on GitHub
#110 (comment)
.

iliajie · 2015-02-19T06:22:16Z

Thanks. Great. No need for test login. Could you please take a screenshot. What are the numbers on the right?

clawrie · 2015-02-19T06:28:17Z

There's a partial screen capture in my previous message. Are the numbers
on the right the 115.12 MB of 1024 MB and 408kB of 1024MB?? I can't see any
other numbers.
If so, it's used vs allocated disk space.

On Thu, Feb 19, 2015 at 4:52 PM, Ilia Rostovtsev [email protected]
wrote:

Thanks. Great. No need for test login. Could you please take a screenshot.
What are the numbers on the right?

—
Reply to this email directly or view it on GitHub
#110 (comment)
.

dreamrae · 2015-02-19T17:21:21Z

Hi! I'm experiencing the same issue. Below is the requested information:

$VAR1 = { 'value' => '612.75 MB of 5 GB', 'chart' => [ '5368709120', 642482176, 32768 ], 'desc' => 'tld_domain.dns' };
$VAR1 = { 'desc' => 'tld_domain.dns2', 'chart' => [ '5368709120', 212992, 32768 ], 'value' => '240 kB of 1024 MB' };
$VAR1 = { 'desc' => 'tld_domain.dns3', 'chart' => [ '5368709120', 196608, 32768 ], 'value' => '224 kB of 1024 MB' };
$VAR1 = { 'desc' => 'tld_domain.dns4', 'chart' => [ '5368709120', 204800, 8192 ], 'value' => '208 kB of 1024 MB' };

iliajie · 2015-02-19T18:34:55Z

Alright, guys! Seems like I got it. Please test it. Replace authentic-lib.cgi in with the updated one: https://rostovtsev.ru/pub/src/authentic/9.5.0-patches/authentic-lib.cgi

dreamrae · 2015-02-19T18:36:52Z

So glad I could help! Thank you Mr. Rostovtsev!

iliajie · 2015-02-19T18:38:43Z

Could you please test it? It should display correct information now. Is it?

dreamrae · 2015-02-19T18:45:43Z

Tested - It is working!

iliajie · 2015-02-19T18:46:52Z

Ohh, yeah!! :) Now let's see what @clawrie says! I think it should also work fine!

Great, thank you guys!

clawrie · 2015-02-19T23:51:53Z

Hi Ilia

That looks to have fixed the issue - thanks very much.

Craig

On Fri, Feb 20, 2015 at 5:16 AM, Ilia Rostovtsev [email protected]
wrote:

Ohh, yeah!! :) Now let's see what @clawrie https://github.com/clawrie
says! I think it should also work fine!

Great, thank you guys!

—
Reply to this email directly or view it on GitHub
#110 (comment)
.

iliajie · 2015-02-20T11:56:27Z

Great! Thanks for reporting!

7starsone · 2015-02-23T14:27:56Z

to me is wrong yet...
168.40 MB of 2 GB reports as 0% while it should be at least 8%

iliajie · 2015-02-23T14:29:18Z

Print an array please.

7starsone · 2015-02-23T14:37:34Z

$VAR1 = {
'chart' => [
'137438953472',
3525713920,
6193991680
],
'value' => '9.05 GB',
'desc' => '<a class='ui_link' href='/virtual-server/edit_domain.cgi?dom=141676138110898'>domain.tld'
};

$VAR1 = {
'chart' => [
'137438953472',
4671164416,
8192
],
'value' => '4.35 GB',
'desc' => '<a class='ui_link' href='/virtual-server/edit_domain.cgi?dom=14167606569562'>domain2.tld'
};

$VAR1 = {
'chart' => [
'137438953472',
176570368,
8192
],
'value' => '168.40 MB of 2 GB',
'desc' => '<a class='ui_link' href='/virtual-server/edit_domain.cgi?dom=141341030325393'>domain3.tld'
};
$VAR1 = {
'chart' => [
'137438953472',
171589632,
1536000
],
'value' => '165.11 MB of 128 GB',
'desc' => '<a class='ui_link' href='/virtual-server/edit_domain.cgi?dom=141676097010212'>domain4.tld'
};
$VAR1 = {
'chart' => [
'137438953472',
56614912,
839680
],
'value' => '54.79 MB of 2 GB',
'desc' => '<a class='ui_link' href='/virtual-server/edit_domain.cgi?dom=141328307217527'>domain5.tld'
};

$VAR1 = {
'chart' => [
'137438953472',
479232,
118784
],
'value' => '584 kB of 4 GB',
'desc' => '<a class='ui_link' href='/virtual-server/edit_domain.cgi?dom=14235034509552'>domain6.tld'
};

.....

iliajie · 2015-02-23T15:01:54Z

Look:

$VAR1 = {
'chart' => [
'137438953472',
479232,
118784
],
'value' => '584 kB of 4 GB',
'desc' => 'domain6.tld'
};

It's totally wrong. Total value (the first one) is never right? I will report it to Webmin developers.

7starsone · 2015-02-23T15:07:15Z

I don't know... 137438953472 is the total value of what? are they bytes?
I have 7 account plans (one of which is the default plan with everything Unlimited, for my personal domain(s) ) and the max plan for users is a 128GB disk quota, instead...
but what has this to do with that total value? or isn't related?

iliajie · 2015-02-23T15:16:33Z

Where do you see of 4 GB on the array. It's not there.. What default theme shows?

7starsone · 2015-02-23T15:18:15Z

Virtualmin framed theme reports the same: 584 kB of 4 GB

iliajie · 2015-02-23T15:19:21Z

I would call it a bug. Will see what Jamie says.

iliajie · 2015-03-03T08:17:45Z

I will fix it very soon in version 10.0.0.

clawrie · 2015-03-03T08:50:15Z

Great. Looking forward to it.

iliajie · 2015-03-04T20:13:35Z

@7starsone I think the reason for the bandwidth problem is in Virtualmin 4.14. I tested it with Virtualmin pre-release 4.15 and all was fine. Let's please wait. I think it will fix the problem.. but I would like to see the screenshot for the bandwidth, as I never seen it on the System Information Page.

7starsone · 2015-03-04T20:41:04Z

ok, the first domain has bandwidth _unlimited_

iliajie · 2015-03-04T20:47:26Z

How does it show in Virtualmin theme? I would guess the same? If so, please report it to Webmin thread right now.

iliajie · 2015-03-04T20:57:05Z

Ahh, OK. No. It's gonna be fixed in Virtualmin 4.15, I think it's out today. ;)

7starsone · 2015-03-04T21:00:47Z

I don't see bandwidth on 4.14 Virtualmin framed theme...
when it comes to Quota i get this error

Error - Perl execution failed
Illegal division by zero at /usr/libexec/webmin/virtual-server-theme/newright.cgi line 104.

is it related?

iliajie · 2015-03-04T21:04:12Z

No worries. It will be fixed in Virtualmin 4.15. I will report a bug for you to Virtualmin.

7starsone · 2015-03-06T13:58:57Z

still issues with 4.15, now I see _not unlimited_ domains only (and this is _good...) _BUT...

iliajie · 2015-03-06T14:00:16Z

Restarted Webmin? ;)

iliajie · 2015-03-06T14:01:31Z

...and 170mb out of 2gb = ~8% - where is the problem here?

7starsone · 2015-03-06T14:04:10Z

yes and..
no, the problems are all the 2% values.... not always correct

iliajie · 2015-03-06T14:05:52Z

Yes, actually it is.. Hmm.. Ok, can you print the array again? That is wierd.. It's all correct on my server..

7starsone · 2015-03-06T14:11:05Z

e.g.

$VAR1 = {
          'chart' => [
                       100,
                       0,
                       0
                     ],
          'value' => '165.11 MB&nbsp;of&nbsp;128 GB',
          'desc' => '<a class=\'ui_link\' href=\'/virtual-server/edit_domain.cgi?dom=141676097010212\'>domain.net</a>'
        };

7starsone · 2015-03-06T14:12:18Z

that should be correct and i don't understand... i cleared cache and restarted webmin..
there's something still to be fixed

7starsone · 2015-03-06T14:15:26Z

[root@myhost ~]# quota thatuser
Disk quotas for user thatuser (uid 506):
     Filesystem  blocks   quota   limit   grace   files   quota   limit   grace
       /dev/md2  167836  134217728 134217728            4533       0       0

iliajie · 2015-03-06T14:45:23Z

authentic-lib.cgi, line 340

replace
$chart_percent

with
$t->{'chart'}[1]

Does it work?

7starsone · 2015-03-06T14:47:56Z

Yes, it works ;-)

iliajie · 2015-03-06T22:14:49Z

Alright, please update to version 10.1.0. Does it fully fix your problem?

drkskwlkr · 2015-03-07T09:31:02Z

Attached VAR output as requested (four quota entries in my list):

$VAR1 = {
'desc' => 'Domain1',
'chart' => [
'1157619712',
818016256,
339603456
],
'value' => '1.08 GB'
};

$VAR1 = {
'desc' => 'Domain2',
'value' => '1.02 GB',
'chart' => [
'1157619712',
1088880640,
6811648
]
};

$VAR1 = {
'desc' => 'Domain3',
'value' => '61.32 MB',
'chart' => [
'1157619712',
61534208,
2760704
]
};

$VAR1 = {
'desc' => 'Domain4',
'value' => '208 kB',
'chart' => [
'1157619712',
212992,
0
]
};

iliajie · 2015-03-07T09:58:40Z

From what I can see you have old buged type output. You ether didn't update Virtualmin or still have old, cache version of the lib files in memory... Try to double check please. When I get to PC I will post more things to check. If it persists will create a bug to Virtualmin team.

drkskwlkr · 2015-03-07T16:14:00Z

I restarted webmin (service webmin restart) and rebooted the server but nothing changed. I am positive that I am running the latest version of Virtualmin (4.15gpl-2)

iliajie · 2015-03-07T17:37:27Z

What is the content of:

authentic-theme/sysinfo.cgi line 40-50
virtual-server/system_info.pl line 285-363

Besides, what is your version of Webmin?

drkskwlkr · 2015-03-07T18:33:07Z

Contents of /usr/share/webmin/authentic-theme/sysinfo.cgi, line 40-50

    : ''
) . '</h3>' . "\n";

print '</div>';
print '<div class="panel-body">' . "\n";

# Get system info to show
my @info = &list_combined_system_info( { 'qshow', 1 } );

if ( $level == 0 ) {

Contents of /usr/share/webmin/virtual-server/system_info.pl, line 285-363

# Top quota users
my @quota = $info->{'quota'} ?
                grep { &can_edit_domain($_->[0]) } @{$info->{'quota'}} : ( );
if (!$data->{'noquotas'} && @quota && (&master_admin() || &reseller_admin())) {
        my @usage;
        my $max = $data->{'max'} || 10;
        my $maxquota = $info->{'maxquota'};

        # Work out if showing by percent makes sense
        my $qshow = $data->{'qshow'};
        if ($qshow) {
                my @quotawithlimit = grep { $_->[2] } @quota;
                $qshow = 0 if (!@quotawithlimit);
                }


        # Limit to those with a quota limit, if showing a percent
        if ($qshow) {
                @quota = grep { $_->[2] } @quota;
                }

        if ($qshow) {
                # Sort by percent used
                @quota = grep { $_->[2] } @quota;
                @quota = sort { ($b->[1]+$b->[3])/$b->[2] <=>
                                ($a->[1]+$a->[3])/$a->[2] } @quota;
                }
        else {
                # Sort by usage
                @quota = sort { $b->[1]+$b->[3] <=> $a->[1]+$a->[3] } @quota;
                }

        # Message above list
        my $qmsg;
        if (@quota > $max) {
                @quota = @quota[0..($max-1)];
                $qmsg = &text('right_quotamax', $max);
                }
        elsif (&master_admin()) {
                $qmsg = $text{'right_quotaall'};
                }
        else {
                $qmsg = $text{'right_quotayours'};
                }

        my $open = 0;
        foreach my $q (@quota) {
                my $cmd = &can_edit_domain($q->[0]) ? "edit_domain.cgi"
                                                    : "view_domain.cgi";
                my $chart = { 'desc' => &ui_link(
                        '/'.$module_name.'/'.$cmd.'?dom='.$q->[0]->{'id'},
                         &show_domain_name($q->[0])) };
                if ($qshow) {
                        # By percent used
                        my $qpc = int($q->[1]*100 / $q->[2]);
                        my $dpc = int($q->[3]*100 / $q->[2]);
                        $chart->{'chart'} = [ 100, $qpc, $dpc ];
                        }
                else {
                        # By actual usage
                        $chart->{'chart'} = [ $maxquota, $q->[1], $q->[3] ];
                        }
                if ($q->[2]) {
                        # Show used and limit
                        my $pc = int(($q->[1]+$q->[3])*100 / $q->[2]);
                        $pc = "&nbsp;$pc" if ($pc < 10);
                        $chart->{'value'} = &text('right_out',
                                                  &nice_size($q->[1]+$q->[3]),
                                                  &nice_size($q->[2]));
                        }
                else {
                        # Just show used
                        $chart->{'value'} = &nice_size($q->[1]+$q->[3]);
                        }
                if ($q->[2] && $q->[1]+$q->[3] >= $q->[2]) {
                        # Domain is over quota
                        $open = 1;
                        }
                push(@usage, $chart);
                }

Webmin version is 1.730

drkskwlkr · 2015-03-07T18:43:46Z

Sure, let's wait and see if the Webmin devs can say something more. I will patch the sysinfo.pl file as suggested && remain at your disposal to troubleshoot this thing. Thank you for your time!

iliajie · 2015-03-07T18:47:11Z

Do you have anything changed in Virtualmin->Configuration, like external/custom commands or something? Or other quotas settings?

drkskwlkr · 2015-03-07T18:52:12Z

No, I don't think so. I am not very experienced in Linux server administration and avoid touching anything whose purpose is not clear to me. I have no custom commands regarding quotas in Virtualmin->Configuration; I have defined the quotas for the different virtual servers via Edit Virtual Server->Quotas and Limits.

drkskwlkr · 2015-03-07T18:56:13Z

Heh. The problem got solved by itself.

I decided to reset the quotas (by writing 2048 MB instead of 2GB) just to see what would happen and as soon as I did this for all four virtual servers, the chart started showing the proper units (I have not yet patched the authentic-theme/sysinfo.pl file).

iliajie · 2015-03-07T20:06:43Z

Alright, it's cache problem. Jamie is aware! Thanks for reporting!

iliajie closed this as completed Feb 20, 2015

iliajie mentioned this issue Feb 23, 2015

Bandwidth Graphs non-functional on System Information page #113

Closed

iliajie mentioned this issue Feb 23, 2015

Quotas array return an issue? webmin/webmin#193

Closed

iliajie mentioned this issue Mar 4, 2015

Adopt/Deliver Authentic Theme as a bundle webmin/webmin#183

Closed

Quotas Bar Charts Incorrect #110

Quotas Bar Charts Incorrect #110

Comments

clawrie commented Feb 17, 2015

iliajie commented Feb 17, 2015

clawrie commented Feb 17, 2015

iliajie commented Feb 17, 2015

iliajie commented Feb 18, 2015

iliajie commented Feb 18, 2015

clawrie commented Feb 18, 2015

clawrie commented Feb 18, 2015

iliajie commented Feb 18, 2015

clawrie commented Feb 19, 2015

iliajie commented Feb 19, 2015

clawrie commented Feb 19, 2015

dreamrae commented Feb 19, 2015

iliajie commented Feb 19, 2015

dreamrae commented Feb 19, 2015

iliajie commented Feb 19, 2015

dreamrae commented Feb 19, 2015

iliajie commented Feb 19, 2015

clawrie commented Feb 19, 2015

iliajie commented Feb 20, 2015

7starsone commented Feb 23, 2015

iliajie commented Feb 23, 2015

7starsone commented Feb 23, 2015

iliajie commented Feb 23, 2015

7starsone commented Feb 23, 2015

iliajie commented Feb 23, 2015

7starsone commented Feb 23, 2015

iliajie commented Feb 23, 2015

iliajie commented Mar 3, 2015

clawrie commented Mar 3, 2015

iliajie commented Mar 4, 2015

7starsone commented Mar 4, 2015

iliajie commented Mar 4, 2015

iliajie commented Mar 4, 2015

7starsone commented Mar 4, 2015

iliajie commented Mar 4, 2015

7starsone commented Mar 6, 2015

iliajie commented Mar 6, 2015

iliajie commented Mar 6, 2015

7starsone commented Mar 6, 2015

iliajie commented Mar 6, 2015

7starsone commented Mar 6, 2015

7starsone commented Mar 6, 2015

7starsone commented Mar 6, 2015

iliajie commented Mar 6, 2015

7starsone commented Mar 6, 2015

iliajie commented Mar 6, 2015

drkskwlkr commented Mar 7, 2015

iliajie commented Mar 7, 2015

drkskwlkr commented Mar 7, 2015

iliajie commented Mar 7, 2015

drkskwlkr commented Mar 7, 2015 • edited by iliajie Loading

drkskwlkr commented Mar 7, 2015

iliajie commented Mar 7, 2015

drkskwlkr commented Mar 7, 2015

drkskwlkr commented Mar 7, 2015

iliajie commented Mar 7, 2015

drkskwlkr commented Mar 7, 2015 •

edited by iliajie

Loading