Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of cosmetic issues in the new notification function (Authentic theme version 17.20) #306

Closed
drkskwlkr opened this issue Dec 21, 2015 · 2 comments

Comments

@drkskwlkr
Copy link

authentic
1 Message content
The message in the Notifications panel needs to be fixed:
There are N package updates are available
The second 'are' is unnecessary. Strangely, this behavior is not influenced when body_upneed=$1 is redacted inside /usr/share/webmin/authentic-theme/lang/en.UTF-8

2 "Hot" notification (red dot with number over the bell icon) will not clear itself after successfully performing update.

3 Language switching
The Notification panel will stay in English when interface language is changed via Webmin > Change Language & Theme

@iliajie
Copy link
Collaborator

iliajie commented Dec 21, 2015

All recommendations are valid and will be fixed in 17.21. Thanks.

@iliajie
Copy link
Collaborator

iliajie commented Dec 24, 2015

1 Message content

Will be fixed in 17.21.

2 "Hot" notification

Notifications are not dependent on anything else. However, if you click on notification, it will be marked as read and will take you to the package updates (or other link, depending on the message).

3 Language switching

Language switching is hardcode for notifications and FIlemin so far and will be fixed in future releases (17.31 - 17.50)

@iliajie iliajie closed this as completed Dec 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants