Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualmin Server Dropdown #326

Closed
davenir opened this issue Jan 8, 2016 · 7 comments
Closed

Virtualmin Server Dropdown #326

davenir opened this issue Jan 8, 2016 · 7 comments

Comments

@davenir
Copy link

davenir commented Jan 8, 2016

Just installed your theme and it seems very impressive. One immediate thing I noticed however was that the older version of the Virtualmin theme italicised disabled severs in the Server drop down menu (top left) while yours does not. This was a very useful feature to identify quickly the status of servers.

Also - a small point; the character limit on the server name in the drop down can be increased (now that your theme uses a smaller font size in the drop down).. but perhaps this is a webmin thing.

Many thanks

@iliajie
Copy link
Collaborator

iliajie commented Jan 8, 2016

Hi,

Yes, you can control the length in Virtualmin Configuration.

I mark disabled servers in red. What version of the theme are you using?

@iliajie
Copy link
Collaborator

iliajie commented Jan 8, 2016

You mean when they are not selected.. I see. Ok. Will do it by 17.40. Thanks.

@davenir
Copy link
Author

davenir commented Jan 8, 2016

Yes exactly Ilia - when they are not selected.
Thanks also for domain character length tip - I never saw that before.

Many thanks

@iliajie
Copy link
Collaborator

iliajie commented Jan 8, 2016

You are welcome. :)

@iliajie
Copy link
Collaborator

iliajie commented Jan 8, 2016

It will be working in 17.40.

Meanwhile, if you want it already just add this to theme->extensions->js the following:

t__wi_p.$("aside select").on("select2:open", function (a) {
    $.each($("select > option"), function () {
        if ($(this).attr("style") && $(this).attr("style").indexOf("italic") > -1) {
            var $this = $(this);
            setTimeout(function () {
                t__wi_p.$("body").find('li[id$="' + $this.attr("value") + '"]').attr("style", "color: #e73c38 !important; font-style:italic !important; ")
            }, 1);
        }
    })
});

Tell me if it's what you expected.

Don't forget to remove it when upgrading to 17.40.

@iliajie iliajie closed this as completed Jan 8, 2016
@davenir
Copy link
Author

davenir commented Jan 8, 2016

FYI - I tried this and it made no difference for me but I'm happy to wait for next version.

010

@iliajie
Copy link
Collaborator

iliajie commented Jan 8, 2016

Well. Save the file and hard reload the theme (Ctrl+R or Shift+Ctrl+R)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants