Mailman Mailing Lists containing "new" have all-green buttons

[ElpyDE]

Hi,

I found a small bug that seems to be related to this theme:

In any table showing mailman mailing lists (per domain or global), the buttons of each list which has new in its name, are shown in green (first screenshot).

It happens that they have the class btn-success assigned for which the background-color is defined in /unauthenticated/css/package.min.css

Example (Delete button of the unnewsworthy list):

<input style="margin-left: 3px;" class="btn btn-default submitter ui_submit btn-danger btn-success heighter-28" name="unnewsworthy" id="unnewsworthy" value="Delete" type="submit">

The old theme does not add any similar classes. This is why I suppose a small bug in the logic which adds classes to buttons in Authentic Theme.

Authentic Theme:

Virtualmin Framed Theme:

Finally: I really like the new authentic theme. It makes using virtualmin fun again. Thanks to anyone who contributed to this great work!

[iliajie]

You are welcome, 😄

I agree that mechanism for guessing colors of the buttons should be improved. I will leave this issue opened until next release - then I'll fix that.

Thank you for reporting.

[iliajie]

If you open right frame content's page, what its URL?

[iliajie]

I mean view-source

[ElpyDE]

The problem occurs at all tables of Virtualmin Mailman Mailing Lists:
Let myhost.example.com be the host where virtualmin is running and example.org be one virtual server on that host. Then the green buttons will be on:
https://myhost.example.com:10000/virtualmin-mailman/ (mailing lists of all virtual servers)
and on
https://myhost.example.com:10000/virtualmin-mailman/index.cgi?show=example.org (mailing lists of only the example.org virtual server)

[iliajie]

It will be fixed upon next release. Please stay tuned and let me know if it's alright after upgrade.

Thanks for reporting.

[iliajie]

17.64 is out, please upgrade.

[ElpyDE]

Green buttons have gone now, thanks for your work!

Unfortunately, the previously red Delete buttons are now gray, too. But that's okay (a confirmation page is shown before any delete action is excecuted) and probably better than accidentally colored buttons, I think.

Without digging further into your code for guessing colors, I'm afraid I cannot suggest any better or even unique selection criteria :-(

[iliajie]

Yes, they should be labeled by the module itself. Other than that it's all guessing and can't be 100% reliable.