Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dansguardian: broken formatting and functionality #426

Closed
jcerqueira opened this issue Mar 21, 2016 · 16 comments
Closed

Dansguardian: broken formatting and functionality #426

jcerqueira opened this issue Mar 21, 2016 · 16 comments
Labels

Comments

@jcerqueira
Copy link

The latest version seems to break the formatting and functionality of the Dansguardian Webmin Module. Works with default theme. Screenshot attached.
screenshot

@iliajie
Copy link
Collaborator

iliajie commented Mar 22, 2016

Thanks for reporting. I'll take a look and try fixing it upon next release.

@iliajie
Copy link
Collaborator

iliajie commented Mar 22, 2016

Could you specify, what exactly is broken?

@jcerqueira
Copy link
Author

It seems to be mostly display issues. On all screens, the submit, cancel, update, etc buttons are all missing labels (they still work but it's a game of Russian roulette trying to figure out which is which). Search for phrase words is completely missing all display and displaying silhouettes for the fields and radio button options. Also, the top banner of the page displays random text and screens. Some are phrases from a previous page that seem to just get stuck and others are just completely random gibberish. Here is a screenshot of the search page with the random text circled.
screenshot2

Thank you for your awesome theme and your time and interest in resolving this!

@iliajie
Copy link
Collaborator

iliajie commented Mar 22, 2016

:) You are welcome!

In few days I will be back fully on working with the theme, I will find where to download this module and try to figure out what is happening.

@jcerqueira
Copy link
Author

https://sourceforge.net/projects/dgwebminmodule/

^This is the project page for that module.

Also I should mention that this was only tested on the latest version of chrome as shown in the screenshots. I can't test in IE as this theme does not work for me in IE. This is what happens when I login on IE 11 (tested on multiple machines and compatibility view made no difference). Have not tried any other browser and unfortunately am not able to do so.

screenshot3

@iliajie
Copy link
Collaborator

iliajie commented Mar 22, 2016

Nothing really works in IE. What you're experiencing is the cache issue. Hard reload the page and you will get it right. Theme works in IE but the only browser that makes the theme work perfectly is Chrome.

@jcerqueira
Copy link
Author

That's what I figured. I never use IE (got IE tab in Chrome for the rare occasions you're forced to use it). Just tried it to see if it was a browser specific issue or something else. Thank you again!

@iliajie iliajie changed the title Dansguardian Module Dansguardian: broken formatting and functionality Mar 23, 2016
@iliajie
Copy link
Collaborator

iliajie commented Mar 29, 2016

That is the interesting issue that you reported. It potentially could have global effect on some modules.

It will be fixed in version 17.80!

Thanks for reporting!

@jcerqueira
Copy link
Author

No problem! And thank you kindly for the replies, fix, time, and an awesome theme! I'll be sure to send a few beers your way in the very near future (money is tight but definitely I will try to scavenge what I can in appreciation!)

@iliajie
Copy link
Collaborator

iliajie commented Mar 29, 2016

I deeply appreciate this, pal!!

@iliajie
Copy link
Collaborator

iliajie commented Mar 29, 2016

😄

@jcerqueira
Copy link
Author

Least I can do for all your hard work and for a theme that makes web-based management via Webmin very stylish and a breeze ;)

Please allow me until next week before being able to do so!

@iliajie
Copy link
Collaborator

iliajie commented Mar 29, 2016

Thank you again.

Please enjoy the theme. There are more improvements coming with 17.80.

@iliajie
Copy link
Collaborator

iliajie commented Apr 8, 2016

Please upgrade 17.80 is out!

@jcerqueira
Copy link
Author

Installed the update and can confirm all is working again. Thank you so much! Hopefully you received my donation as well and keep up the amazing work!

@iliajie
Copy link
Collaborator

iliajie commented Apr 8, 2016

:) Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants