Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webminstats: Refresh problem as of missing meta tags in theme's header #436

Closed
gerbier opened this issue Apr 13, 2016 · 6 comments
Closed

Comments

@gerbier
Copy link

gerbier commented Apr 13, 2016

The webminstats module goal is to display graphs about system or applications parameters.
It is using the standard ui_print_header sub, and use the 9th parameter ( head-stuff ) to add

in html header.

With the last authentic-theme releases, I do not find anymore my meta line in html code (and the graph does not resfresh). Does authentic-theme rewrites html headers ?

@iliajie
Copy link
Collaborator

iliajie commented Apr 13, 2016

Hi,

As you can see, I didn't really override ui_print_header function.

I'm just guessing that you not doing debugging the right way? What is not working for you now what worked in 17.72? Did you double check?

@iliajie iliajie closed this as completed Apr 13, 2016
@iliajie iliajie reopened this Apr 13, 2016
@iliajie
Copy link
Collaborator

iliajie commented Apr 14, 2016

Any luck with this?

@gerbier
Copy link
Author

gerbier commented Apr 14, 2016

I checked yesterday on fresh debian 8 with authentic-theme, then with the default theme (gray theme).
I just had a look at html code (CTRL+U on firefox), and I do not find my meta refresh when I use authentic-theme.
I just tests again today on a Mageia 5, I have the same result.

I use webmin 1.791 and authentic-theme 17.83

@iliajie
Copy link
Collaborator

iliajie commented Apr 15, 2016

Hi,

I was checking through my code and installed all other versions of the theme, down to 14.00 - I could not find <meta http-equiv=Refresh content=60> that is produced by your meta_refresh() (it seems to be always an issue, not latest release ).

I could see the meta tags being displayed by running Gray Theme but like I mentioned and as you can see by looking at the theme's code - I do nothing with ui_print_header.

Later I found out that my theme didn't print 7th argument for the header. I have fixed that and it will be working as expected on 17.84+.

Thanks for reporting! ;)

@iliajie iliajie closed this as completed Apr 15, 2016
@iliajie iliajie changed the title refresh problem on webminstats module Webminstats: Refresh problem as of missing meta tags in theme's header Apr 15, 2016
@iliajie
Copy link
Collaborator

iliajie commented Apr 15, 2016

17.84 is out. Please upgrade.

@gerbier
Copy link
Author

gerbier commented Apr 16, 2016

Hi

I just upgrade and check : it's working again : thanks for this quick release !

----- Mail original -----

17.84 is out. Please upgrade.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants