Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Manager: File compression to zip has no output #437

Closed
divyeshsachan opened this issue Apr 13, 2016 · 8 comments
Closed

File Manager: File compression to zip has no output #437

divyeshsachan opened this issue Apr 13, 2016 · 8 comments

Comments

@divyeshsachan
Copy link

Hi,
While New->create new archive-> select .zip format ends up with message "compression has successfully finished." but it results in no output file.
Where as .tar.gz.is working fine.

Please check and confirm

@iliajie
Copy link
Collaborator

iliajie commented Apr 13, 2016

Hi,

The most possible reason why this is happening is that you don't have zip command installed or it's not on the path. Try whereis zip on the CLI, what is the output? If non install zip.

It's working fine on my side.

The good point is to add a notification for the user to install zip.

@iliajie
Copy link
Collaborator

iliajie commented Apr 14, 2016

Tried it?

@divyeshsachan
Copy link
Author

Apologize for delayed response.
I checked, zip was not installed in my machine, after installing zip everything worked perfectly.

Now, the point is, instead of showing "compression has successfully finished." message to those users who don't have zip installed show them some error message like "zip is not installed, compression unsuccessful." or to prompt them to install zip before continuing. It'll be clear to those users who don't have zip.

Thanks :-)

@iliajie
Copy link
Collaborator

iliajie commented Apr 14, 2016

Yes, I think I'll add it to my extensions.

@iliajie
Copy link
Collaborator

iliajie commented Apr 15, 2016

Alright,

17.84+ will show user-friendly message, in case zip command is not installed - Example

@iliajie iliajie closed this as completed Apr 15, 2016
@iliajie
Copy link
Collaborator

iliajie commented Apr 15, 2016

17.84 is out. Please upgrade.

@divyeshsachan
Copy link
Author

That's perfect.... :-)

@iliajie
Copy link
Collaborator

iliajie commented Apr 16, 2016

Thanks. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants