Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: ConfigServer Security & Firewall 9.20+ UI is broken with Authentic Theme 18.10 #547

Closed
jobhh opened this issue Sep 19, 2016 · 27 comments

Comments

@jobhh
Copy link

jobhh commented Sep 19, 2016

CSF updated their UI for version 9.20, see https://download.configserver.com/csf/changelog.txt. I updated my backup server to test it and it seems like Authentic doesn't know how to handle the new UI and just reloads my Virtualmin home page (System Information).

Steps to reproduce:

  1. Update to CSF 9.20
  2. Go to the CSF settings page, https://myserver.mine:10000/csf
  3. Just wait a second (while looking at the updated UI) and see it return to https://myserver.mine:10000

A complete reboot of the system did not fix it and Incognito mode produced the same results.

Server:
Webmin 1.810
Virtualmin 5.04
Authentic Theme 18.10
Debian Linux 8.6

PC:
Windows 10 Academic 64bit
Chrome 53 64bit

This is what the CSF page looks like before reloading into the System Information page:
2016-09-19 1

Am I correct in assuming quite some theme conversion code can be stripped Authentic now? CSF is now natively based on Bootstrap, so only changing the CSS will already make it fit in quite a bit.

@iliajie
Copy link
Collaborator

iliajie commented Sep 19, 2016

I'm glad that I've inspired CSF team to finally move on. :D .. and yes, I expected this after reading logs.

I will take a look at it.

At the moment, the best would be is to comment out /usr/(libexec|share)/webmin/authentic-theme/extensions/csf.min.js.

It will take much more work to support it.

@iliajie iliajie changed the title CSF 9.20 Redesigned UI based on Bootstrap Theme: ConfigServer Security & Firewall 9.20+ UI is broken with Authentic Theme 18.10 Sep 19, 2016
@iliajie
Copy link
Collaborator

iliajie commented Sep 19, 2016

I have made a request, will see if support is going to be able to provide plain version of the module (as before), without extras loaded.

https://forum.configserver.com/viewtopic.php?f=6&t=9762&p=27029#p27029

@iliajie
Copy link
Collaborator

iliajie commented Sep 20, 2016

It will be supported in next version of the theme, presumably 18.20 in the middle of October.

@mvander
Copy link

mvander commented Sep 20, 2016

Great. Thank you!

@paolokappa
Copy link

Jesus, in the middle of October... can't wait so long :D
We definitely love your theme.
Could you release an intermediate small patch to fix this issue?

@iliajie
Copy link
Collaborator

iliajie commented Sep 21, 2016

I explained how to disable it and make it at least work. (by purging csf.min.js)

Well, I will try to make it sooner but I can't promise. I have very serious project to finish right now.

@paolokappa
Copy link

Thanks Ilia, I did it and now it’s properly working.

Cheers,

Paolo Caparrelli

[logoRidotto]http://www.goline.ch/

Da: Ilia Rostovtsev [mailto:[email protected]]
Inviato: mercoledì, 21. settembre 2016 11:12
A: qooob/authentic-theme [email protected]
Cc: Goline SA - IT Services [email protected]; Comment [email protected]
Oggetto: Re: [qooob/authentic-theme] Theme: ConfigServer Security & Firewall 9.20+ UI is broken with Authentic Theme 18.10 (#547)

I explained how to disable it and make it at least work. (by purging csf.min.js)

Well, I will try to make it sooner but I can't promise. I have very serious project to finish right now.


You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com//issues/547#issuecomment-248555241, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHkdBmTOPcBupeQe2MKcx3_Fm3zeJf7bks5qsPTbgaJpZM4KATRW.

@alnork
Copy link

alnork commented Sep 25, 2016

temporary solution in centos 6.7:
rm /usr/libexec/webmin/authentic-theme/extensions/csf.min.js -f

@iliajie
Copy link
Collaborator

iliajie commented Sep 25, 2016

Yes, exactly!

@SteffanCline
Copy link

I did the rm trick above to make mine work but the dashboard shows the wrong status on CentOS 7. It says it's not running but when you go to the CSF page, it says it IS running.

@iliajie
Copy link
Collaborator

iliajie commented Sep 29, 2016

Yes, there were a lot of changes in CSF recently. They are moving on.

I will fix all of it and try to add new features. Getting back to it on October 12. ;)

@montgomerykern
Copy link

I have been experiencing the same issues with CSF but in the interim i have been opening a new tab from the dashboard and working in CSF on its own independent tab or window and it seems to have resolved most of my issues.

Might I suggest that from the left hand menu that its changed to open in a new tab until fixes have been issued by all.

Cheers!!

@CanadianJeff
Copy link

whats the status of this bug? is it solved?

@alnork
Copy link

alnork commented Oct 3, 2016

October 12

@iliajie
Copy link
Collaborator

iliajie commented Oct 3, 2016

Yeah, October 12 I'll start and make a fix release within a week or so. There are a lot of issues as you probably saw.

It works if you delete the file, so its usable for a little while.

@alnork
Copy link

alnork commented Oct 13, 2016

@qooob What happened with upgrade?

@jobhh
Copy link
Author

jobhh commented Oct 13, 2016

@alnork Qooob said he would start working on it on October 12. I think we can assume he didn't finish it in 1 day. He said it would take about a week, so if it's still unreleased in 1-2 weeks we can ask what's up.

@alnork
Copy link

alnork commented Oct 13, 2016

mmmmmm ok.... thanks!

@iliajie
Copy link
Collaborator

iliajie commented Oct 13, 2016

Yes, this is correct, @jobhh, thanks. I'm already working on the new release.

@iliajie
Copy link
Collaborator

iliajie commented Oct 28, 2016

I have finally fixed that and made it look hot again.

It will take few more days before you guys could enjoy it in 18.20

It took a lot of time. Sorry for delay!!

@alnork
Copy link

alnork commented Oct 28, 2016

Good news ... Bravo !!!

@SteffanCline
Copy link

Will this also fix the issue where it says csf is not running when it really is?

@iliajie
Copy link
Collaborator

iliajie commented Oct 28, 2016

It should.

@iliajie iliajie closed this as completed Oct 28, 2016
@iliajie
Copy link
Collaborator

iliajie commented Oct 29, 2016

Version 18.20 is out, please upgrade.

I hope you will enjoy it!

@alnork
Copy link

alnork commented Oct 29, 2016

thaaaaaaanks a lot @qooob

@iliajie
Copy link
Collaborator

iliajie commented Oct 31, 2016

Please read and re-update the theme over again.
#568

@iliajie
Copy link
Collaborator

iliajie commented Nov 1, 2016

Third wave is ready: #568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants