Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Safari Private Browsing mode breaks the theme #592

Closed
matrix200 opened this issue Dec 7, 2016 · 11 comments
Closed

Theme: Safari Private Browsing mode breaks the theme #592

matrix200 opened this issue Dec 7, 2016 · 11 comments
Labels

Comments

@matrix200
Copy link

matrix200 commented Dec 7, 2016

18.30 works in Safari so long as I am not using Private Browsing mode. In Private Browsing mode, the two sidebars show up, but never anything more than an endless blue spinner in the main content area.

This is in contrast to 18.20 working great in Safari using Private Browsing mode. Attached are the console errors when using Private Browsing mode:
screen shot 2016-12-07 at 10 16 00 pm

@iliajie iliajie changed the title Can you please make the version 18.2 available for download. Version 18.30 completely breaks down webmin 1.8.20_1 on centos 6.8 Theme: 18.30 after update issue on CentOS 6.8 Dec 7, 2016
@iliajie iliajie closed this as completed Dec 7, 2016
@itmustbe
Copy link

itmustbe commented Dec 8, 2016

I had this same issue and it really scared me briefly (feeling locked out of my server with the endless looping loading graphic in the center of the screen), not knowing how to change to a working theme! Switching from Safari with Private Browsing to Chrome fixed it for me for the moment :) Really scared me though because logging into my server with Webmin has been working just fine in Safari with Private Browsing, right up until I clicked the button to update the Authentic theme from 18.20 to 18.30 (tried logging out and then back in too using Safari). In my Dev Tools inspector the errors were all of this form: [Error] QuotaExceededError (DOM Exception 22): The quota has been exceeded. (in init.min.js and parent.min.js) I'm on CentOS 6.8 with Webmin 1.821

@iliajie
Copy link
Collaborator

iliajie commented Dec 8, 2016

It's intended by Safari in private mode browsing. It doesn't support localStorage.setItem()

@iliajie
Copy link
Collaborator

iliajie commented Dec 8, 2016

It will be fixed in 18.31

@iliajie iliajie changed the title Theme: 18.30 after update issue on CentOS 6.8 Theme: Safari Private Browsing mode breaks the theme Dec 8, 2016
@iliajie
Copy link
Collaborator

iliajie commented Dec 8, 2016

18.31 is out, please upgrade.

@itmustbe
Copy link

itmustbe commented Dec 8, 2016

That was fast! Works great again with 18.31, thanks so much!

@iliajie
Copy link
Collaborator

iliajie commented Dec 8, 2016

You're welcome. It wasn't fast, really but thanks!

@matrix200
Copy link
Author

Not for me.
Still the same error screen.

@iliajie
Copy link
Collaborator

iliajie commented Dec 8, 2016

  1. Make sure that the theme has been updated
  2. Clear browser's cache.
  3. Restart the browser, then Webmin/Usermin

In case it's not solved, provide the screenshot with console opened to see an error.

@matrix200
Copy link
Author

Did all that.
Same error, same screen, that Elise has shared.
Also tried incognito mode with the same result.

@iliajie
Copy link
Collaborator

iliajie commented Dec 8, 2016

:)

Provide extra details. Otherwise I can't help.

@matrix200
Copy link
Author

OK I will try to do some more testing tomorrow, its midnight here and I really need to hit the sack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants