Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualmin: Backup schedule chooser doesn't work #619

Closed
garas opened this issue Dec 20, 2016 · 4 comments
Closed

Virtualmin: Backup schedule chooser doesn't work #619

garas opened this issue Dec 20, 2016 · 4 comments
Labels

Comments

@garas
Copy link

garas commented Dec 20, 2016

When trying to add complex schedule for backup, popup window opens, but confirming changes fails.

  • Go to Virtualmin > Backups and Restore > Scheduled Backups.
  • Add new or edit existing backup schedule.
  • Under "Schedule and reporting" choose "Complex schedule".
  • Click button to open popup /virtual-server/cron_chooser.cgi.
  • Change any setting, error console gets TypeError: form.special_def is undefined error.
  • Button "OK" doesn't work, parent window doesn't update.

Using "Virtualmin Framed Theme" works as expected.

Theme 18.31 and Webmin 1.821 versions installed.
Browser Firefox 51

@iliajie
Copy link
Collaborator

iliajie commented Dec 20, 2016

Hi,

It's confirmed.

I will try to make a patch within few days.

@iliajie iliajie changed the title Backup schedule chooser doesn't work Virtualmin: Backup schedule chooser doesn't work Dec 20, 2016
@iliajie iliajie added the bug label Dec 20, 2016
@iliajie
Copy link
Collaborator

iliajie commented Dec 20, 2016

Actually, it works if you hit Submit button?

@garas
Copy link
Author

garas commented Dec 20, 2016

Yes, it works with Submit button. So the fix is probably to remove one of button, leaving working one.

"Virtualmin Framed Theme" has only OK button.

Error console error happens in both themes, so probably unrelated.

@iliajie
Copy link
Collaborator

iliajie commented Dec 20, 2016

Hmm. I'll take a look.

iliajie pushed a commit that referenced this issue May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants