Theme: Favorites file (favorites.json) might have to get garbage data

[mateusz-szafraniec]

System/Webmin language: PL-UTF8

When something from Webmin menu is added to favorites, and it contains national character like "ś", "ó" etc, it causes Webmin crash, displaying blank page:
For example: Dislay system log ("Wyświetl log"):

HTTP/1.0 500 Perl execution failed
Server: MiniServ/1.820
Date: Thu, 29 Dec 2016 10:21:22 GMT
Content-type: text/html; Charset=iso-8859-1
Connection: close
<h1>Error - Perl execution failed</h1>
<pre>Wide character in syswrite at /usr/share/webmin/miniserv.pl line 3083.
</pre>

Content of favorites.json:
{"favorites":[ { "link": "/syslog/save_log.cgi?oidx=0&omod=fail2ban&view=1", "title": "System/Logi systemowe: Wyświetl log", "icon": "webmin" } ]}&_=1483006733460

[iliajie]

Hi,

Thanks for reporting.

I will reproduce it and try to fix it a bit later.

[iliajie]

Hi,

I can't reproduce it.

Are you sure that you have UTF-8 type of language set in both Webmin Configuration -> Language and Change Language and Theme?

[mateusz-szafraniec]

Yes, i have UTF-8 in both options.
Please try to copy&paste provided example of favorites.json

[iliajie]

Could you update to the latest Webmin 1.830?

[mateusz-szafraniec]

I have it already, problem still exists. On Ubuntu and Debian. Try something witch character ś
After that, please reload whole page - Ctrl-F5.

[iliajie]

I still can't reproduce it.

The reason why it fails is because you have &_=1483006733460 in the file. Remove it manually and try again.

[mateusz-szafraniec]

Problem still exists, please have a look:
https://www.youtube.com/watch?v=yDRnbcV-Fw0&feature=youtu.be

[iliajie]

Hi,

Mateusz. I have watched closely your video. I will do my best to reproduce it and fix it upon next release.

I have downloaded your video. You can delete it from YouTube.

[iliajie]

I could reproduce it.

Working on the fix.

[iliajie]

Have a try with the fix 945c625

[mateusz-szafraniec]

Nope, problem still exists...
{"favorites":[ { "link": "/fail2ban/", "title": "Sieć/Fail2Ban - detektor intruzów: Fail2Ban - detektor intruzów", "icon": "webmin" }, { "link": "/lpadmin/", "title": "Sprzęt/Zarządzanie drukarkami: Zarządzanie drukarkami", "icon": "webmin" }, { "link": "/package-updates/", "title": "System/Aktualizacja pakiet�w oprogramowania: Aktualizacja pakiet�w oprogramowania", "icon": "webmin" } ]}

`

Error - Perl execution failed

Wide character in syswrite at /usr/share/webmin/miniserv.pl line 3087. `

[iliajie]

I can say that I copy/paste your JSON string. It works just fine. It loads without any problem.

What is your OS and the setup? Can you still reproduce this issue?

[iliajie]

Try mine, does it fail with your setup?

Here is how my favorites.json look like:

{"favorites":[
    {
        "link": "/fail2ban/",
        "title": "Nie-używane moduły/Fail2Ban - detektor intruzów: Fail2Ban - detektor intruzów",
        "icon": "webmin"
    },
    {
        "link": "/package-updates/",
        "title": "System/Aktualizacja pakietów oprogramowania: Aktualizacja pakietów oprogramowania",
        "icon": "webmin"
    },
    {
        "link": "/lpadmin/",
        "title": "Sprzęt/Zarządzanie drukarkami: Zarządzanie drukarkami",
        "icon": "webmin"
    }
]}

[iliajie]

No, really. It just works.