Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Apache Webserver' config screen link to external page is broken #82

Closed
samatcd opened this issue Feb 3, 2015 · 3 comments
Closed

'Apache Webserver' config screen link to external page is broken #82

samatcd opened this issue Feb 3, 2015 · 3 comments

Comments

@samatcd
Copy link

samatcd commented Feb 3, 2015

Under the URL column, clicking 'Open' is supposed to open a link to the actual website, however it looks like Authentic is hijacking the request, and attempting to AJAX in the page.

screen shot 2015-02-03 at 10 57 33 pm

This link only exists after selecting 'Display virtual servers as list' in Module Config.

Console outputs:
Refused to frame 'https://external.domain/' because it violates the following Content Security Policy directive: "frame-src 'self'".

You may need to further filter 'a' elements with href's that begin with an external address.

@iliajie
Copy link
Collaborator

iliajie commented Feb 3, 2015

Alright, I fixed it. It's actually Webmin bug I believe, because simply it would be easier just to add to all external links target="_blank".

Now theme will check for all external links on click and if it's the case (if it's external), will open it in new window to prevent errors.

@iliajie iliajie closed this as completed Feb 3, 2015
@iliajie
Copy link
Collaborator

iliajie commented Feb 3, 2015

It's fixed in 9.0.3. Please update.

@samatcd
Copy link
Author

samatcd commented Feb 3, 2015

Thats great, thanks — works very well :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants