Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Improve error handling by bypassing ParseError and ShellError #52

Closed
cassaundra opened this issue Mar 26, 2024 · 1 comment · Fixed by #53
Closed

Improve error handling by bypassing ParseError and ShellError #52

cassaundra opened this issue Mar 26, 2024 · 1 comment · Fixed by #53
Labels
enhancement New feature or request
Milestone

Comments

@cassaundra
Copy link
Collaborator

Currently, in functions which are required to emit ShellErrors (such as in nushell Commands), we convert the internal diagnostic to a ShellError::GenericError, which is quite lossy. The same is the case for parse errors.

To circumvent this lossy conversion, we can push errors instead to the quake engine itself, and handle them independently of nushell engine errors.

@cassaundra cassaundra added the enhancement New feature or request label Mar 26, 2024
@cassaundra cassaundra added this to the quake 0.1.0 milestone Mar 26, 2024
@cassaundra
Copy link
Collaborator Author

Adding on to this: should refactor calls to exit inside of the engine with a EngineError result type.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant