Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change prefix for configuration properties from quarkus.operator-sdk to qosdk? #733

Open
metacosm opened this issue Sep 28, 2023 · 4 comments
Assignees

Comments

@metacosm
Copy link
Member

This would be shorter to type and would also bypass conversion issues between env variables and property names.

@kdubb
Copy link

kdubb commented Dec 5, 2023

This seems like a pretty big departure from Quarkus norms for a Quarkiverse project (which all live under quarkus.), for a few keystrokes.

Just dropping the -sdk. would get you nearly the same savings; and even then I don't think it's worth the deviation.

@metacosm
Copy link
Member Author

metacosm commented Dec 5, 2023

This seems like a pretty big departure from Quarkus norms for a Quarkiverse project (which all live under quarkus.), for a few keystrokes.

Indeed, but then again, I think that having everything with the same prefix makes it useless to have the prefix because it becomes just noise. So I feel that switching to qosdk as the prefix would streamline things and make it easier for folks to discover and type properties (even when there's no auto-completion available).

Just dropping the -sdk. would get you nearly the same savings; and even then I don't think it's worth the deviation.

Dropping the -sdk part is needed because this will remove ambiguity during the env <-> property name conversion process which has and is causing issues.

@kdubb
Copy link

kdubb commented Dec 5, 2023

make it easier for folks to discover and type properties (even when there's no auto-completion available).

Objectively this will make it harder. Right now I know, without looking anywhere, it's the plugin name... so starts quarks.operator-sdk. or QUARKUS_OPERATOR_SDK_. Migrating from this will require me to look it up.

Maybe just alias them to some other root?

@metacosm
Copy link
Member Author

metacosm commented Dec 5, 2023

make it easier for folks to discover and type properties (even when there's no auto-completion available).

Objectively this will make it harder. Right now I know, without looking anywhere, it's the plugin name... so starts quarks.operator-sdk. or QUARKUS_OPERATOR_SDK_. Migrating from this will require me to look it up.

An example of the problem is how does Quarkus knows that QUARKUS_OPERATOR_SDK_ maps to a property named quarkus.operator-sdk or quarkus.operator.sdk?

Don't get me wrong, I get your points but there's a real issue at the moment with the prefix.

Maybe just alias them to some other root?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants