Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: How to disable Probes, e.g. livenessProbe? #818

Closed
Jeansen opened this issue Feb 5, 2024 · 8 comments
Closed

[Question]: How to disable Probes, e.g. livenessProbe? #818

Jeansen opened this issue Feb 5, 2024 · 8 comments
Assignees

Comments

@Jeansen
Copy link

Jeansen commented Feb 5, 2024

I have the need to disable probes. But nothing so far worked. I was able to overwrite settings, e.g. the initial delay, but the quarkus kubernetes extensions does not offer any options and the smallrye-health options for disabling that extension did not work either. Every time I have all probes with some defaults set in the generated kubernetes.yml, for example

          livenessProbe:
            failureThreshold: 3
            httpGet:
              path: /q/health/live
              port: 8080
              scheme: HTTP
            initialDelaySeconds: 5
            periodSeconds: 10
            successThreshold: 1
            timeoutSeconds: 10

So, my questions is, how do I disable this? I am aware, this is not directly specific to the QOSDK extension, but since these two extensions are a dependency, I thought, I start here. Maybe I am just blind in the tunnel .....

@Jeansen Jeansen changed the title Questions: How to disable Probes, e.g. livenessProbe? [Question]: How to disable Probes, e.g. livenessProbe? Feb 5, 2024
@metacosm
Copy link
Member

metacosm commented Feb 6, 2024

Indeed, there seems to be an issue: quarkusio/quarkus#38613

@metacosm
Copy link
Member

May I ask why you need to deactivate the probes, actually? Considering making the probes controlled by a QOSDK property, just trying to figure out what the use case is to see if it makes sense…

@Jeansen
Copy link
Author

Jeansen commented Feb 13, 2024

I would like to disable them during development. Probes are the last thing I add, when a POC, MVP etc goes stable. It's exactly the phase when I have something I would like to be build via CI/CD, but where I am still "trying out things". Also, there might be security reasons to not expose probes until reviewed by a security responsible. For instance, for some insurance company, some rules are extraordinarily strict with respect to what exactly is allowed to be exposed.

Of course, this can all be overwritten, but that's exactly the point. I would have to overwrite many settings with dummy values or add some dummy code, which would be removed later on. But being able to deactivate probes, would simply be the easiest AND also reflect the intention. Anyway, it would be easy to pick it up during a review, after all.

If I would seed an application setting that says, e.g: livenessProbe=false, I would quickly notice it and also be able to ask: Why is this disabled? Serving a dummy probe or overwriting it with some dummy settings IMHO a code/config smell.

@xstefank
Copy link
Member

xstefank commented Aug 8, 2024

Hi @Jeansen, I implemented the config disable of the health extension in Quarkus, which also skips adding the probes to the generated resources—quarkusio/quarkus#42361. Please try this with the next Quarkus release and let us know if it solves your case here.

@Jeansen
Copy link
Author

Jeansen commented Aug 11, 2024

Hes @xstefank That's great news! Thank you. I'll post my feedback, then.

@xstefank
Copy link
Member

Hi @Jeansen, just checking if we can close this issue?

@Jeansen
Copy link
Author

Jeansen commented Oct 22, 2024

@xstefank I am deeply sorry, I did not find the time yet. I think you can close it. I'll reopen it, if I should have any issues. Slack time is short for me at the moment to do some work with respect to this issue ... ;-(

@xstefank
Copy link
Member

No worries @Jeansen, I was just checking. I think your proposal sounds good so please reopen this issue if you hit the problem again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants