Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate the data types between simple and composite #11

Open
patacca opened this issue Jun 21, 2023 · 0 comments
Open

Seperate the data types between simple and composite #11

patacca opened this issue Jun 21, 2023 · 0 comments
Assignees
Labels
refactoring Refactoring part of the code

Comments

@patacca
Copy link
Collaborator

patacca commented Jun 21, 2023

Right now the data types are divided in "simple" (word, dword, ascii, etc...) and "structure" (structure, union, enum).
Imho this is not a good choice of words as the term "structure" could either mean a proper "structure" (like a C struct) or the collection of data types (struct, union and enum).

I propose to refactor the data types to add enum as a "simple" type (after all it's not a composite type, its fields' type are homogeneous) and rename the "structure" type to "composite". A "composite" data type would be either a struct or a union, making it in fact a heterogeneous type.

More tests need to be done to prove that a enum can effectively be moved into the "simple" types.

@patacca patacca added the refactoring Refactoring part of the code label Jun 21, 2023
@patacca patacca self-assigned this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring part of the code
Projects
None yet
Development

No branches or pull requests

1 participant