RESTEasy Reactive: paths not properly uri-decoded before matching

[FroMage]

Describe the bug

Our URI-matching does not properly match uri-encoded values that are legal path segments. We rely on Vert.x RoutingContext.normalizedPath() which only decodes percent-encoded chars from the unreserved category (see https://www.rfc-editor.org/rfc/rfc3986#section-2.4) but other values which are allowed as part of the path segment will not be decoded prior to matching:

   segment       = *pchar
   segment-nz    = 1*pchar
   segment-nz-nc = 1*( unreserved / pct-encoded / sub-delims / "@" )
                 ; non-zero-length segment without any colon ":"

   pchar         = unreserved / pct-encoded / sub-delims / ":" / "@"

   query         = *( pchar / "/" / "?" )

   fragment      = *( pchar / "/" / "?" )

   pct-encoded   = "%" HEXDIG HEXDIG

   unreserved    = ALPHA / DIGIT / "-" / "." / "_" / "~"
   reserved      = gen-delims / sub-delims
   gen-delims    = ":" / "/" / "?" / "#" / "[" / "]" / "@"
   sub-delims    = "!" / "$" / "&" / "'" / "(" / ")"
                 / "*" / "+" / "," / ";" / "="

In theory, in a segment, the characters "!" / "$" / "&" / "'" / "(" / ")" / "*" / "+" / "," / ";" / "=" / ":" / "@" do not need to be encoded, but they can, and so if we have an endpoint declared for /$ we should match both /$ and /%24 which decodes to the same thing.

To reproduce:

@Path("/")
public class Endpoint {
 @GET
 @Path("$")
 public String ok() { return "OK"; }
}

Now call wget 'http://localhost:8080/$' and wget 'http://localhost:8080/%24', both should return OK and match the same endpoint.

At the moment, only the first one works. This probably fails for all the other characters I've listed above.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @Sgitario (resteasy-reactive), @geoand (resteasy-reactive), @stuartwdouglas (resteasy-reactive)

[FroMage]

Reproducing project: https://github.com/FroMage/urlencodingbug

[geoand]

Is this still a problem?

[FroMage]

Unfortunately, yes. I updated the reproducer project.