Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we update S2iBaseJavaImage and OpenshiftBaseJavaImage? #36577

Closed
gsmet opened this issue Oct 19, 2023 · 7 comments · Fixed by #37349
Closed

Should we update S2iBaseJavaImage and OpenshiftBaseJavaImage? #36577

gsmet opened this issue Oct 19, 2023 · 7 comments · Fixed by #37349

Comments

@gsmet
Copy link
Member

gsmet commented Oct 19, 2023

I was looking for something else entirely and stumbled upon S2iBaseJavaImage and OpenshiftBaseJavaImage where I was surprised we didn't have anything more recent than JDK 11 for instance.

Maybe it's expected but I thought I should ask.

/cc @iocanel @geoand @cescoffier

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 19, 2023

/cc @geoand (openshift), @iocanel (openshift)

@gsmet
Copy link
Member Author

gsmet commented Nov 28, 2023

@iocanel pinging you again here as this is becoming problematic if we want to move to Java 17 entirely.

@gsmet
Copy link
Member Author

gsmet commented Nov 28, 2023

/cc @maxandersen too

@cescoffier
Copy link
Member

Hey @maxandersen @iocanel, the list of images looks very outdated. I don't believe we should recommend using these partially unmaintained images. Can you explain how these images are used and try to see how we can curate this list? Note that I don't see Java 17 and 21 in the list - which is kind of annoying... Java 11 is so 2018...

@iocanel
Copy link
Contributor

iocanel commented Nov 28, 2023

I think that we can just drop them. I think that we've been migrating away from them to the point they should be no longer used

@iocanel
Copy link
Contributor

iocanel commented Nov 28, 2023

Hmmm, the native one is still used.

@iocanel
Copy link
Contributor

iocanel commented Nov 28, 2023

Ages ago, we introduced these to magically set things like needed env variables, paths etc based on the selected image.
As, maintaining those was becoming an issue and also too much magic was adding confusion, we decided to move away from these. At the moment they have no effect, as the images that they reference are too old.

I'll create a PR to wipe them.

@cescoffier cescoffier removed their assignment Nov 30, 2023
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants