-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build cache - Disable cache for modules with tests having programmatic dependencies #37388
Comments
/cc @gwenneg (cache) |
@gsmet I had a look at #37349 and I'm unable to find the first build which didn't run the ITs (as you mentioned there). I have however tried to simulate a similar case:
What I'm seeing is:
So it does seem to build Am I missing something? |
@gsmet if you have more info for me (see previous comment) I can have a look next week. |
Indeed, it's not a problem for GIB in this case. So have a happy holiday without this to figure out :) |
@famod ^ |
Haha, alright - thanks. Happy holiday for you too @gsmet! |
In our codebase, we have tests for which we are dynamically adding a dependency specifically for a test. These dependencies are not tracked anywhere and thus are not input of the build cache.
It's a problem for the build cache but it's also a problem for GIB as GIB don't see these dependencies either.
We got hit by that here: #37349
The text was updated successfully, but these errors were encountered: