Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS - don't overwrite default functions #10608

Closed
cscheid opened this issue Aug 26, 2024 · 0 comments · Fixed by #10796
Closed

SCSS - don't overwrite default functions #10608

cscheid opened this issue Aug 26, 2024 · 0 comments · Fixed by #10796
Assignees
Labels
bug Something isn't working html Issues with HTML and related web technology (html/css/scss) themes Related to HTML theming or any other style related issue (like highlight-style)
Milestone

Comments

@cscheid
Copy link
Collaborator

cscheid commented Aug 26, 2024

See #10529 (reply in thread) for context.

(cc @gadenbuie)

The problem is that it's hard to tell if anyone is relying on this function.

That's fair, but I don't think we declare this function as part of Quarto's public API. The real problem is that Quarto doesn't (and will never) have a sharply defined API boundary to begin with. But, if anything, that argues for making such fixes sooner rather than later.

@cscheid cscheid added the bug Something isn't working label Aug 26, 2024
@cscheid cscheid added this to the v1.6 milestone Aug 26, 2024
@cscheid cscheid self-assigned this Aug 26, 2024
@mcanouil mcanouil added html Issues with HTML and related web technology (html/css/scss) themes Related to HTML theming or any other style related issue (like highlight-style) labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html Issues with HTML and related web technology (html/css/scss) themes Related to HTML theming or any other style related issue (like highlight-style)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@cscheid @mcanouil and others