Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include broker details in metadata #119

Open
jrha opened this issue Jul 27, 2018 · 4 comments
Open

Include broker details in metadata #119

jrha opened this issue Jul 27, 2018 · 4 comments

Comments

@jrha
Copy link
Member

jrha commented Jul 27, 2018

Would this be a good idea?

In particular it would be nice to have the version of the broker written to the host plenary, but having the broker's host-name might also be useful. This would allow us to track roll-outs of changes which only take effect as the plenaries are rebuilt as well as letting us build in time-bombs for any workarounds that get upstream fixes.

/metadata/broker/version?
/metadata/broker/servername?

@stdweird
Copy link
Member

at some point i also proposed to do this for panc by panc, but i can't remember why we choose not to. i'll try to find issue...

@ned21
Copy link
Contributor

ned21 commented Jul 27, 2018

version number

This would cause all profiles to change on every release. Since we release weekly, I would be not keen on this.

servername

We already have this because one of our services is aqd, so the server name appears in /system/services/aqd/... This allows to bind hosts to e.g. a beta broker for testing new functionality with real hosts. Any reason you could not do the same?

@jrha
Copy link
Member Author

jrha commented Jul 30, 2018

This would cause all profiles to change on every release. Since we release weekly, I would be not keen on this.

Do you flush after every release?

@ned21
Copy link
Contributor

ned21 commented Jul 30, 2018

This would cause all profiles to change on every release. Since we release weekly, I would be not keen on this.
Do you flush after every release?

No. I see there's an interesting angle there: if we added this but didn't flush we would be able to tell which version of the broker generated the host plenary. But then that gets confusing because it may be including plenaries generated by other versions of the broker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants