Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move react app into separate repo #51

Closed
davidanthoff opened this issue Dec 2, 2019 · 1 comment
Closed

Move react app into separate repo #51

davidanthoff opened this issue Dec 2, 2019 · 1 comment
Assignees

Comments

@davidanthoff
Copy link
Member

Ok, I've changed my mind again :) But now that I understand the structure of all of this better, I think @TonyLianLong you were right to suggest we put the actual react app into a separate repo. I created one at https://github.com/julia-vscode/plotgallery and gave you access rights for that. Can you just add the whole content of the folder electron-display-react to that repo and remove it from the PR for this repo here?

And then we will add the content of the build folder here into the ElectronDisplay repo. I think for now we can just manually copy things in here.

But as you pointed out, with such a structure it should be easier to use the same code for electron display and inside VS Code itself.

@davidanthoff
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants