Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logging output #173

Open
marten-seemann opened this issue Sep 9, 2020 · 0 comments
Open

improve logging output #173

marten-seemann opened this issue Sep 9, 2020 · 0 comments

Comments

@marten-seemann
Copy link
Collaborator

Removing all the pyshark output definitely helped, but I'd like a bit more. For instance, take this output:

Saving logs to ./logs.
Expected exactly 1 handshake. Got: 3
Expected at least 2 ClientHellos. Got: 0
Expected exactly 2 handshake. Got: 4
Missing files: ['dleshiaewf']
Expected 50 handshakes. Got: 46
Missing files: ['wjrfeuzvmi']
Expected 50 handshakes. Got: 48
Missing files: ['arwuloafqh']
Missing files: ['nxgwhmfkkg']
Missing files: ['htjehiteld']
Run took 0:11:58.096941
Server: quant. Client: msquic. Running test case: handshake
Server: quant. Client: msquic. Running test case: transfer
Server: quant. Client: msquic. Running test case: longrtt
Server: quant. Client: msquic. Running test case: chacha20
Server: quant. Client: msquic. Running test case: multiplexing
Server: quant. Client: msquic. Running test case: retry
Server: quant. Client: msquic. Running test case: resumption
Server: quant. Client: msquic. Running test case: zerortt
Server: quant. Client: msquic. Running test case: http3
Server: quant. Client: msquic. Running test case: blackhole
Server: quant. Client: msquic. Running test case: handshakeloss
Server: quant. Client: msquic. Running test case: transferloss
Server: quant. Client: msquic. Running test case: handshakecorruption
Server: quant. Client: msquic. Running test case: transfercorruption
Server: quant. Client: msquic. Running test case: goodput
Server: quant. Client: msquic. Running test case: crosstraffic
+--------+------------------+
|        |      quant       |
+--------+------------------+
| msquic |        H         |
|        |      Z3C20       |
|        | LRRDCSMC1L1BC2L2 |

IMO, things would be a lot better if the output was modified so that it prints which test is being run, then any errors, and then the final result. Something more like:

Saving logs to ./logs.

Server: quant. Client: msquic. Running test case: handshake
Success

Server: quant. Client: msquic. Running test case: transfer
Expected exactly 1 handshake. Got: 3
Failure

Server: quant. Client: msquic. Running test case: longrtt
Expected at least 2 ClientHellos. Got: 0
Failure
...

fyi, @marten-seemann I don't seem to have the permissions to reactivate the issue.

Originally posted by @nibanks in #158 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant