feat(fe): add warning for 'let({x} = y);' #1211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new diagnostic E0720 that closes quick-lint#1203. Issues a warning when a function let() is called on an object assignment expression. quick-lint#1203
strager
requested changes
Mar 13, 2024
E0720 diagnostic did not properly check whether the callee is the 'let' function. The naming of the diagnostic was also changed to use 'confusing' instead of 'ambiguous' to more accurately reflect the underlying issue.
The documentation for E0720 did not follow the usual format and did not properly explain what the issue was and how to fix it.
|
@strager Thank you for the feedback! I have made the necessary corrections to the pull request. |
|
Landed your patch as Git commit c8b3258. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new diagnostic E0720 that closes #1203. Issues a warning when a function let() is called on an object assignment expression.
#1203