-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error if calling a string/template/number literal #611
Comments
Hi! I am in an intro to swe class that is requiring me to work on my first open-source project. I was wondering if this issue is still open and if so could I get help with my first contribution? |
Yes, this task is still open. I can definitely help you with this task if you have problems. I can answer questions here or weekdays on my Twitch stream (https://twitch.tv/strager). (However, I'm on a vacation right now, so my availability is spotty until January 26.) cc @singalhimanshu who can help if I'm not around. |
Ok perfect thank you so much! |
@Ishvina let me know if you are facing any issues. |
@singalhimanshu Hi! Thank you. Can you tell me where to begin and where I should find these errors? |
Have you done the project setup? Are you able to run quick-lint-js on js files? If not follow the instructions here - https://github.com/quick-lint/quick-lint-js/blob/master/docs/BUILDING.md |
I usually start by reproducing the problem. In this case, the problem is that quick-lint-js reports no error, but Node.js does report an error (when the code runs). I'd reproduce by creating a .js file and running quick-lint-js and Node.js on the .js file. (You need to build quick-lint-js from source by following the instructions @singalhimanshu linked.) Then, I'd write a test case. I'd probably write a test in |
Hi! I am taking an intro class that requires me to work on my first open-source project. I noticed that this issue was assigned two months ago but has not been resolved. If this issue is still open, could I be assigned it? |
@Ishvina Are you still working on this task? |
If @Ishvina does not respond, would I be able to receive assignment for this task. Also, because I'm still new to open source contribution, would it be possible to get guidance/assistance if need be? |
Yes.
Yes, of course. |
@mketer1 Do you still want to work on this task? |
Hey @strager can I work on this task? |
@fk00750 You may. |
@fk00750 Are you still working on this task? Do you need any help? |
Hello! Has this been resolved yet? If not I'm also interested in trying to solve this |
Hi @strager, has this issue been resolved? I would like to give it a go. |
@adrperez5 It looks like there were a lot of people who accepted the task then disappeared. Maybe this task is haunted... Are you sure you want to take it on? |
I will try my best! |
5 is called as if it was a function. We should report an error for trivial cases like this.
In the future, we might want to provide a nice diagnostic suggesting inserting a semicolon in cases like the following (suggested by elliot416):
The text was updated successfully, but these errors were encountered: