Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use quickemu --vm /path/to/vm.conf --kill to stop virtual machines #170

Closed
1 task done
flexiondotorg opened this issue Jun 30, 2024 · 0 comments · Fixed by #174
Closed
1 task done

feat: use quickemu --vm /path/to/vm.conf --kill to stop virtual machines #170

flexiondotorg opened this issue Jun 30, 2024 · 0 comments · Fixed by #174
Assignees
Labels
enhancement New feature or request

Comments

@flexiondotorg
Copy link
Member

I confirm this feature has not been previously requested

  • I have searched the issues and this feature has not previously been requested

Is your feature request related to a problem? Please describe.

Quickgui currently uses killall and the VM name as process identifier to stop/kill a running VM: https://github.com/quickemu-project/quickgui/blob/main/lib/src/pages/manager.dart#L344

QEMU for macOS is unable to set a virtual machine's process name and, therefore, cannot stop/kill a virtual machine in this fashion.

Quickemu 4.9.6 has a reliable --kill argument that uses the .pid file for the given VM to identify the virtual machine and kill/stop it.

Describe the solution you'd like

Once #169 is implemented, Quickgui should:

  • On Linux, use quickemu --vm /path/to/vm.conf --kill if Quickemu 4.9.6 or newer is available.
    • And fallback to the killall mechanism if Quickemu 4.9.5 or older is found.
  • On macOS, use quickemu --vm /path/to/vm.conf --kill if Quickemu 4.9.6 or newer is available.
    • Disable the stop button if Quickemu 4.9.5 or older is found.

Describe alternatives you've considered

Quickemu looks up the process ID from the .pid file for the given VM and implements a native Dart cross-platform mechanism to kill the virtual machine.

Additional context

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant