Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NodeStateSnapshot #149

Open
fulmicoton opened this issue May 1, 2024 · 1 comment · May be fixed by #151
Open

Remove NodeStateSnapshot #149

fulmicoton opened this issue May 1, 2024 · 1 comment · May be fixed by #151
Assignees
@trinity-1686a

Comments

@fulmicoton
Copy link
Contributor

NodeState already holds a chitchat id. I could not find the point of having a NodeStateSnapshot object.
@RNabel RNabel linked a pull request Aug 24, 2024 that will close this issue
Open
@RNabel
Copy link

RNabel commented Aug 24, 2024

This seemed like a good starter task - it looks like you're right and the NodeStateSnapshot struct isn't required (see my draft PR). Do you think this is good to be merged as-is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trinity-1686a trinity-1686a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove NodeStateSnapshot RNabel/chitchat
3 participants
@fulmicoton @RNabel @trinity-1686a