Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up early-data state-machine interactions #17

Open
kaduk opened this issue Jun 29, 2021 · 0 comments
Open

tidy up early-data state-machine interactions #17

kaduk opened this issue Jun 29, 2021 · 0 comments

Comments

@kaduk
Copy link
Member

kaduk commented Jun 29, 2021

Promoting my comment at quictls/openssl#8 (comment) to a more discoverable issue:
When we successfully return from the handshake as a client, we have to check if the early-data state was in SSL_EARLY_DATA_CONNECTING and set it to a new value to indicate that we can no longer send early data (since we got handshake data from the server and should send with 1-RTT keys). The current code sets SSL_EARLY_DATA_WRITE_RETRY, but IMO SSL_EARLY_DATA_FINISHED_WRITING is more appropriate; ossl_statem_check_finish_init() would translate the former into the latter eventually anyway, IIUC.

@richsalz richsalz transferred this issue from quictls/openssl Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant