-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax module does not correctly highlight multi-line comments #723
Comments
One line blocks are not a problem by itself. There are many benefits to it such as consistent newline creation/deletion, at any position across all supported platforms, which is why the implementation choice was made in the first place. The incorrect highlighting for multiline is the target bug that needs to be fixed, which may or may not be done with a one line per block implementation. |
I don't think there's a solution for consistent multi-line highlighting that doesn't run into the same problem / trade-off, just like you get with lists. We could make the One thing I tried was making |
I'm not ready to give up on a solution yet and force all Quill users to make a configured tradeoff. The solution may not be apparent yet but that does not mean it does not exist. |
This is exactly the issue that I came across, although I noticed it with the |
Looking forward to this being released as a beta build. |
Reproducable with the example editor at beta.quilljs.com:
We should wrap them in a single
<pre/>
similar to how lists are wrapped by<ol/>
:The text was updated successfully, but these errors were encountered: