Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered list does not increment properly if use all 8 indent levels #873

Closed
sachinrekhi opened this issue Aug 19, 2016 · 2 comments
Closed

Comments

@sachinrekhi
Copy link
Contributor

Ordered list works great, except in the extreme case when you attempt to use all 8 supported indent levels. After using the 8th indent level, then when you un-indent, the previous indent levels are no longer incrementing properly.

Steps for Reproduction

  1. Visit quilljs.com
  2. Create a list with 0, 1, 2, 3, 4, 5, 6, 7, 8 and indent each at their respective indent level
  3. After 8, un-indent one level

Expected behavior:
The un-indented bullet should be labeled b.

Actual behavior:
The un-indented bullet is labeled a.

screen shot 2016-08-19 at 4 33 27 pm

Platforms:
Chrome 52 on Mac 10.11

Version:
Quill 1.0 RC 0

@jhchen
Copy link
Member

jhchen commented Aug 20, 2016

Quill's stylesheet only covers 8 levels with the thinking that most real documents would only actually utilize up to 4 levels. The obvious solution is to increase this number but then the question is what should the limit be? I'm not aware of a way to cover infinite levels.

@sachinrekhi
Copy link
Contributor Author

Oh 8 levels is certainly plenty, my point was that it looks like it in-fact only supports 7 levels even though it looks like it supports 8 given how the subsequent numbering is incorrect after you use all 8 levels.

My proposal is just to ensure when you indent to 8 levels, the subsequent un-indented numbering works fine. Or alternatively prevent indenting to level 8, where the subsequent un-indented numbering no longer works (so just support 7 levels).

@jhchen jhchen closed this as completed in 024cd3f Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants