Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1256 Don’t create a list when list format is disabled #1257

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Fixes #1256 Don’t create a list when list format is disabled #1257

merged 1 commit into from
Jan 18, 2017

Conversation

haugstrup
Copy link
Contributor

This fixes #1256 by not running the normal keyboard handler code if the list format is not enabled

@jhchen
Copy link
Member

jhchen commented Jan 15, 2017

Thanks for the report and PR. I prefer to have the fix at a lower level since the keyboard is only one place where a list can be created.

@jhchen jhchen closed this Jan 15, 2017
@haugstrup
Copy link
Contributor Author

Even better 🎉 🙇

@jhchen jhchen reopened this Jan 18, 2017
@jhchen jhchen merged commit 75b9a37 into slab:develop Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List created even when list format is disabled
2 participants
@haugstrup @jhchen