use DOM API instead of attribute for "selected" option in dropdowns #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://developer.mozilla.org/en-US/docs/Web/API/HTMLOptionElement The Option element exposes a "selected" getter that works even when the "selected" attribute is not set, such as when the element is created by React or manipulated. Fixes react-quill#175.
alexkrolick
changed the title
|
Demo of the change: https://codepen.io/alexkrolick/pen/awRxWz?editors=0010 Note that the highlighted values in the toolbar don't reset to default with the Snow theme in React-Quill, which is another bug (zenoamaro/react-quill#175). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/HTMLOptionElement
The Option element exposes a "selected" getter that works even when the "selected" attribute is not set, such as when the element is created by React.
Another way to do this is to provide an alternate data attribute to identify the default.
Codepen link demonstrating what happens when an initial "selected" attribute is not present on any of custom option tags for ql-align: https://codepen.io/alexkrolick/pen/qjMrEN?editors=0010
Fixes zenoamaro/react-quill#226.