Header/paragraph doesn't reset list numbering in Firefox #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhchen
approved these changes
Jan 22, 2021
DokaRus
pushed a commit
to DokaRus/devextreme-quill
that referenced
this pull request
Mar 25, 2021
Header/paragraph doesn't reset list numbering in Firefox (cherry picked from commit eeb976e)
DokaRus
added a commit
to DevExpress/devextreme-quill
that referenced
this pull request
Mar 26, 2021
* Merge pull request slab#3223 from luin/ignore-nested-quill-mutations Ignore mutations happens in nested Quill instance (cherry picked from commit 8ce3ee3) * Merge pull request slab#3272 from luin/firefox-bullet Header/paragraph doesn't reset list numbering in Firefox (cherry picked from commit eeb976e) * allow list completion on lists and headers (cherry picked from commit a6911aa) * fix arrow keying past list item - in chrome it take two left arrows to go to prev list item - in firefox ctrl+left does not work (cherry picked from commit 9d16aa5) * fix breaking list items Without this a string with no space on a line will cause the break to occur after the bullet but with it a string with spaces may not break at the space. The latter is much more common and also the choice Paper makes (cherry picked from commit 232b6f4) * Merge branch 'fix-cut-format' * Merge pull request slab#3293 from quilljs/firefox-checkbox Fix checkbox not checkable on Firefox (cherry picked from commit 1f0530a) Co-authored-by: Jason Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducible steps:
2. The second list should start with 1 but in Firefox it starts with 3.The reason is Firefox changes its counter behavior recently: https://bugzilla.mozilla.org/show_bug.cgi?id=1679712. We are using
counter-resetto set the numbering to 0. However, in Firefox, it actually creates a new counter instead of reset the existing one.To fix, the PR uses
counter-set, and if it's not supported fallback tocounter-reset.Browser behaviors for reference:
Test plan:
Make sure the numbering of the example above looks correct in all browsers.