Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not create quilt package on failure #quilt-laronde #103

Closed
drernie opened this issue Jul 25, 2023 · 4 comments · Fixed by #105
Closed

do not create quilt package on failure #quilt-laronde #103

drernie opened this issue Jul 25, 2023 · 4 comments · Fixed by #105
Assignees

Comments

@drernie
Copy link
Member

drernie commented Jul 25, 2023

Right now, nf-quilt will create a package (even if the job fails), because it still receives a "publish" message.

Can/should we skip package creation based on other flags?

nf-vrVgpfHNB4IZT.log

@drernie
Copy link
Member Author

drernie commented Jul 25, 2023

There seems to be a failedCount attribute. Can that be used?

stats: WorkflowStats[succeededCount=45; failedCount=1; ignoredCount=0; cachedCount=91; pendingCount=0; submittedCount=0; runningCount=0; retriesCount=0; abortedCount=0; succeedDuration=1d 22h 27m 42s; failedDuration=2m 41s; cachedDuration=7d 21h 54m 4s;loadCpus=0; loadMemory=0; peakRunning=44; peakCpus=264; peakMemory=1.5 TB; ]

@drernie
Copy link
Member Author

drernie commented Jul 25, 2023

There's also a success attribute that's set to false

scriptId:f421ddc35d81a0561685927c03e03995, revision:null, exitStatus:1, stubRun:false, nextflow:nextflow.NextflowMeta(version:23.04.2, build:5870, timestamp:08-06-2023 08:29 UTC, preview:nextflow.NextflowMeta$Preview@65018381, enable:nextflow.NextflowMeta$Features@75a0e0c2, dsl2:true, dsl2Final:true, strictModeEnabled:false), stats:WorkflowStats[succeededCount=45; failedCount=1; ignoredCount=0; cachedCount=91; pendingCount=0; submittedCount=0; runningCount=0; retriesCount=0; abortedCount=0; succeedDuration=1d 22h 27m 42s; failedDuration=2m 41s; cachedDuration=7d 21h 54m 4s;loadCpus=0; loadMemory=0; peakRunning=44; peakCpus=264; peakMemory=1.5 TB; ], resume:true, success:false, projectName:LarondeInc/rnaseq, scriptName:main.nf, duration:1h 18m 54s], quilt:[package_id:QuiltPackage.nextflowtower_nextflow_INV3746h_Quilt, uri:quilt+s3://nextflowtower#package=nextflow%2fINV3746h_Quilt]]

@drernie drernie self-assigned this Jul 25, 2023
@drernie
Copy link
Member Author

drernie commented Jul 25, 2023

## stats: WorkflowStats[succeededCount=45; failedCount=1; ignoredCount=0; cachedCount=91; pendingCount=0; submittedCount=0; runningCount=0; retriesCount=0; abortedCount=0; succeedDuration=1d 22h 27m 42s; failedDuration=2m 41s; cachedDuration=7d 21h 54m 4s;loadCpus=0; loadMemory=0; peakRunning=44; peakCpus=264; peakMemory=1.5 TB; ]
Jul-11 23:17:24.706 [main] INFO  nextflow.quilt.QuiltProduct - 
## resume: true
Jul-11 23:17:24.706 [main] INFO  nextflow.quilt.QuiltProduct - 
## success: false
Jul-11 23:17:24.706 [main] INFO  nextflow.quilt.QuiltProduct - 
## projectName: LarondeInc/rnaseq
Jul-11 23:17:24.707 [main] INFO  nextflow.quilt.QuiltProduct - 
## scriptName: main.nf
Jul-11 23:17:24.707 [main] INFO  nextflow.quilt.QuiltProduct - 
## duration: 1h 18m 54s

@drernie
Copy link
Member Author

drernie commented Jul 26, 2023

From #quilt-seqera

check session.isSuccess() before publishing the quilt package
alwaysPublish flag to override

@drernie drernie linked a pull request Jul 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant