Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce debug logging #116

Closed
drernie opened this issue Aug 23, 2023 · 6 comments · Fixed by #117
Closed

Reduce debug logging #116

drernie opened this issue Aug 23, 2023 · 6 comments · Fixed by #117

Comments

@drernie
Copy link
Member

drernie commented Aug 23, 2023

We don't need ALL this debugging information. Mainly just:

  • which Quilt URIs are used for input and output
  • the exact quilt3 commands
  • whether things succeed
@drernie drernie changed the title Trim log files Reduce debug logging Aug 23, 2023
@drernie
Copy link
Member Author

drernie commented Aug 23, 2023

Convert non-fatal errors to warnings

@drernie drernie linked a pull request Aug 23, 2023 that will close this issue
@theJasonFan
Copy link

Hi! Thanks for the plugin!

FWIW there's also this one here:

log.error("failed to install $packageName")

I think this error gets hit whenever a new package is created. Tracing the path in the source, setup() is called here

and setup() calls install().

@drernie
Copy link
Member Author

drernie commented Feb 14, 2024

Thanks. this is causing issues in both directions. I will try to wrangle it down next week.

@drernie drernie reopened this Feb 14, 2024
@drernie
Copy link
Member Author

drernie commented Jun 13, 2024

Seems resolved

@drernie drernie closed this as completed Jun 13, 2024
@drernie
Copy link
Member Author

drernie commented Sep 18, 2024

@theJasonFan If you are still seeing issues, please try to reproduce with 0.8.6 or later

# export NXF_VER=23.04.3
export LOG4J_DEBUG=true  # for verbose logging
export NXF_PLUGINS_TEST_REPOSITORY=https://github.com/quiltdata/nf-quilt/releases/download/0.8.6/nf-quilt-0.8.6-meta.json
nextflow run main.nf -plugins [email protected]

@theJasonFan
Copy link

@drernie Thanks for closing the issue. If I run into this issue again I will try to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants