Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move featured scenarios from pro to beta #1431

Open
6 tasks
mabijkerk opened this issue May 16, 2024 · 5 comments
Open
6 tasks

Move featured scenarios from pro to beta #1431

mabijkerk opened this issue May 16, 2024 · 5 comments
Assignees

Comments

@mabijkerk
Copy link
Member

In the PR for Heat improvements (#1386), a migration was run on an outdated nl2019 dataset. The dataset was fixed before deploying to pro. This means that the scenarios on pro have been migrated properly, but the scenarios on beta haven't. The goal therefore is to move the II3050v2 and IP2024 scenarios from pro to beta.

  • II3050v2 scenarios for 2050
  • II3050v2 scenarios for 2040
  • IP2024 scenarios for 2035
  • IP2024 scenarios for 2030
  • KEV scenarios for 2030
  • IP2024 scenarios for 2025

@kndehaan is this something you could pick up? We should aim to do so before beta gets to far ahead of pro again.

@noracato could you list the instructions on how to do so?

@mabijkerk mabijkerk changed the title Move scenarios from pro to beta Move featured scenarios from pro to beta May 16, 2024
@noracato
Copy link
Member

noracato commented Jun 6, 2024

This is done, right @kndehaan? Can we close?

@kndehaan
Copy link
Contributor

kndehaan commented Jun 6, 2024

@noracato unfortunately not yet.. It turns out that I still don't get the same values from the featured scenarios on pro to beta. I think obtaining balanced values could be a piece of the puzzle. I get back to you on how to obtain balanced values from scenarios through the API.

@kndehaan
Copy link
Contributor

I'm quite stuck here. I've updated the featured scenarios on beta with the scenario user_values, custom curves and custom orders. However, there's still a difference in the dashboard item values between the pro and beta.

I added functionalities to scenario-tools to get the custom curves and custom orders (quintel/scenario-tools#40), as well as balanced user values (still work in progress on upload-improvements branche). I get the correct output here.

However, when trying to upload the same settings, the following don't seem to work:

  • set custom orders (excluding heat network orders which is already working on production) through upload_custom_order in the ETM_API
  • set balanced values through update_inputs_balanced_values in the ETM_API
    The following DO work:
  • set custom curves
  • set user values (except for flh_xxx_user_curve

So the not-working components is something where @noracato or @louispt1 could have a look some time? I think something goes wrong in the upload_xxx functions, see the working branche upload-improvements (it's quite in draft so ignore all comments and unfinished functions).

However, when I manually copy paste the user values, balanced values and custom orders from the pro to the beta scenarios in ETEngine, and when the custom curves are all uploaded, I would expect the same scenario outcomes. Is there something that I'm missing? @noracato can you have a look at this..? We could also have a look together.

@noracato
Copy link
Member

Sorry to hear @kndehaan! We'll do our best to unstuck you!

I think the balanced values are not processed very well by the API. But as they are auto balanced, passing the argument autobalance: true to the request where you set the sliders should do the trick as well. (At least hypothetically)

The custom order API did change end of last year. I remember updating it for heat networks indeed. Let's check if the other custom orders also need a similar update!

Copy link

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label Aug 13, 2024
@mabijkerk mabijkerk removed the Stale Issue had no activity for 60 days and will be, or has been, closed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants