Fixes for several issues with new heat modelling in built environment #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the new Fever calulation the parent share for the consumption losses loss edge is still unknown at the time of installing the adapter in a heat network. As this parent share is always 0 (no losses need to calculated) or 1 (losses do need to be calculated) it should be safe to remove it from the calculation
… installment for Merit participants
This was
linked to
issues
Feb 20, 2024
This was referenced Feb 20, 2024
noracato
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up issues that arised during testing of #1386
Largely tackles #1389, but there remain some minor deltas. This issue is kept open.
Closes #1390
Closes #1391
Closes #1392
Closes #1395
Closes #1400