Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV importer should check for negative numbers #164

Open
michieldenhaan opened this issue Feb 1, 2019 · 3 comments
Open

CSV importer should check for negative numbers #164

michieldenhaan opened this issue Feb 1, 2019 · 3 comments

Comments

@michieldenhaan
Copy link
Contributor

Currently it is possible to add negative numbers (and maybe non-numeric values as well?) to the database using the CSV import feature. This causes datasets to break when exporting to ETSource. It would be nice if the importer throws an error when the CSV contains negative/non-numeric values (except for the geo_id and name fields which do contain non-numeric values)

Copy link

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale label Jul 23, 2024
@mabijkerk
Copy link
Member

@noracato do we even still have a CSV importer feature?

@noracato
Copy link
Member

Yes, the CSV importer is used for all the data migrations. I think it wouldn't hurt to add some extra validators to it at one point.

@mabijkerk mabijkerk added Pinned and removed Stale labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants