feat(createScanDialog): issues/1 scan creation options #25
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 58.94% 61.93% +2.99%
==========================================
Files 83 85 +2
Lines 1929 2002 +73
Branches 316 324 +8
==========================================
+ Hits 1137 1240 +103
+ Misses 665 640 -25
+ Partials 127 122 -5
Continue to review full report at Codecov.
|
cdcabrera
changed the title
|
|
||
| TouchSpin.defaultProps = { | ||
| className: '', | ||
| labelMax: <Icon type="fa" name="plus" />, |
There was a problem hiding this comment.
might consider an sr-only span to help with accessibility
There was a problem hiding this comment.
updated: so it looks like we were already hiding the buttons for min and max and just exposing the input field with a aria-hidden. The field can still be wrapped with a label, so thinking we're safe, least for pf3 accessibility.
edit: admittedly this does bypass the accessibility problem all together, which isn't great
What was broken for sure was the ability to be notified when the field validation updated inside the dialog. So went back and added the aria-live attributes to the two most recent parts we updated... the Add Source Wizard, and the Scans dialog covered by this PR
There was a problem hiding this comment.
... and yeahhhhhh its a little sad on the expanded bits, on the upside removing the subsequent ajax calls the expanded state was forced to handle did improve overall load time
* build, react framework updates * styles, forms clean up, touchspin form adjustments * apiConstants, organize, submit scanName, scanSources added * scanActions, duplicate action addStartScan, associated constant * scansEditReducer, link scanAction, addStartScan, hide show modal type * sources view, move lifecycle concepts to sourcesReducer state * sourcesListItem, restructure and testing updates * redux actions, constants, reducers clean up and testing updates * touchspin, component added * createScanDialog, added scan creation options
* scansEditReducer, submit error messaging * helpers, getMessages expanded
* build, react framework updates * styles, forms clean up, touchspin form adjustments * helpers, getMessages expanded * apiConstants, organize, submit scanName, scanSources added * scanActions, duplicate action addStartScan, associated constant * scansEditReducer, scanAction, addStartScan, display modal, errors * sources view, move lifecycle concepts to sourcesReducer state * sourcesListItem, restructure and testing updates * redux actions, constants, reducers clean up and testing updates * touchspin, component added * createScanDialog, added scan creation options
* build, react framework updates * styles, forms clean up, touchspin form adjustments * helpers, getMessages expanded * apiConstants, organize, submit scanName, scanSources added * scanActions, duplicate action addStartScan, associated constant * scansEditReducer, scanAction, addStartScan, display modal, errors * sources view, move lifecycle concepts to sourcesReducer state * sourcesListItem, restructure and testing updates * redux actions, constants, reducers clean up and testing updates * touchspin, component added * createScanDialog, added scan creation options
What's included
How to test
Coverage and basic unit test check
$ yarn$ yarn testInteractive unit test check
$ yarn$ yarn test:devCode
$ yarn$ yarn start:stageto start up a local running instance of the API against development codeExample
Updates issue/story
#1 #18