Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build, aboutModal, helpers): issues/29 version display #31

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Mar 25, 2019

What's included

  • feat(build, aboutModal, helpers): issues/29 version display

    • build, version script added, dotenv updated
    • aboutModal, add UI version information
    • helpers, add the ability to copy and paste version information

Notes

  • the version for the GUI currently pulls from the package.json file... the hash pulls from the last commit. This may need to be flipped over to pulling from the tag instead, but for this round the intention is to keep package.json in sync.

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install or $ yarn
  2. $ npm test or $ yarn test

Interactive unit test check

  1. update the NPM packages with $ npm install or $ yarn
  2. $ npm run test:dev or $ yarn test:dev

Run the UI

  1. clone the repo, create a branch, pull the changes
  2. cd into the repo, update the NPM packages with $ yarn, if you don't have yarn installed you can use brew or $ npm install yarn -g, next
  3. make sure Docker is running, then
  4. $ yarn start:review ... this should compile the image, then run the container with the latest changes
  5. Navigate and open the About modal located here

Screen Shot 2019-03-28 at 2 58 17 PM

Example

Local run staging example

Screen Shot 2019-03-28 at 2 54 11 PM

Local run review example

Screen Shot 2019-03-28 at 3 04 22 PM

Updates issue/story

#29

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #31 into master will decrease coverage by 0.39%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #31     +/-   ##
=========================================
- Coverage   61.93%   61.53%   -0.4%     
=========================================
  Files          85       85             
  Lines        2015     2015             
  Branches      326      323      -3     
=========================================
- Hits         1248     1240      -8     
- Misses        644      653      +9     
+ Partials      123      122      -1
Impacted Files Coverage Δ
src/components/aboutModal/aboutModal.js 45.45% <11.76%> (-29.55%) ⬇️
...rc/components/createScanDialog/createScanDialog.js 41.37% <0%> (-4.34%) ⬇️
src/components/sources/sourceListItem.js 44.31% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98eab26...500f5d2. Read the comment docs.

@cdcabrera cdcabrera force-pushed the issues/29 branch 2 times, most recently from b56259a to cc2b426 Compare March 28, 2019 18:47
@cdcabrera cdcabrera changed the title WIP feat(aboutModal): issues/29 version display feat(aboutModal): issues/29 version display Mar 28, 2019
@cdcabrera cdcabrera changed the title feat(aboutModal): issues/29 version display feat(build, aboutModal, helpers): issues/29 version display Mar 28, 2019
Copy link

@bclarhk bclarhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@himmAllRight himmAllRight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 😄

* build, version script added, dotenv updated
* aboutModal, add UI version information
* helpers, add the ability to copy and paste version information
@cdcabrera cdcabrera merged commit 7af215a into quipucords:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants