Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): issues/29 version display #43

Merged
merged 2 commits into from
Apr 5, 2019

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(build): issues/29 version display
    • display version on creation
    • integration test for version

Notes

  • the unit test checks the format [string]=[number].[number].[number].[7 character hash]

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test:integration

Or build the version file yourself

  1. run $ yarn build:version

Example

Running $ yarn build:version should produce output similar to...
Screen Shot 2019-04-04 at 5 02 12 PM

Updates issue/story

#29

@codecov-io
Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   62.17%   62.17%           
=======================================
  Files          85       85           
  Lines        2028     2028           
  Branches      325      325           
=======================================
  Hits         1261     1261           
  Misses        645      645           
  Partials      122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6700a9b...3a78fd4. Read the comment docs.

* display version on creation
* integration test for version
@cdcabrera cdcabrera merged commit e48a322 into quipucords:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants