fix(reportsService): issues/52 name report package download

[cdcabrera]

What's included

• fix(reportsService): issues/52 name report package download
  • reportsService, move to axios, add responseType
  • helpers, remove downloadPackage in favor of downloadData

Notes

• This corrects the naming issue around the report by adding in the tar.gz. The current package download generates the name based on the browser, which can be confusing... Chrome labels it download.gz and Firefox labels it [some hash].gz. To round it out the file doesn't open on RHEL without the tar in there, this fix corrects all of that.

How to test

Coverage and basic unit test check

1. update the NPM packages with $ yarn
2. $ yarn test

Run the Dev UI

The Dev UI can be used for a quick confirmation on just the file name coming through. Trying to unzip it will create an infinite loop of annoyance since the tar.gz isn't legit.

1. update the NPM packages with $ yarn
2. make sure Docker is running, then
3. $ yarn start
4. Next, navigate to the scans page, you should see what appears to be randomized data. Go ahead and hit the download button, if you don't see a download button on scans, refresh the page until you do. Then check your download directory to confirm the file name appears as report_id_[HUGE RANDOM ID]_[DATE]_[TIME].tar.gz

Run the Review UI

To fully test the package name is successfully you'll need to run

1. update the NPM packages with $ yarn
2. make sure Docker is running, then
3. $ yarn start:review ... this should compile the image, then run the container with the latest changes
4. Next you'll need to generate a successful report. That means setting up a source, running a scan. Then navigate to the scans view, download the package. Within your download directory you should see report_id_[ID]_[DATE]_[TIME].tar.gz. The file should expand accordingly and provide you with a directory containing
   • report_id_[ID]
     • deployments.csv
     • deployments.json
     • details.csv
     • details.json

Example

...

Updates issue/story

fixes #52

[codecov-io]

Codecov Report

Merging #54 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   69.12%   69.13%   +0.01%     
==========================================
  Files          91       91              
  Lines        2131     2132       +1     
  Branches      338      338              
==========================================
+ Hits         1473     1474       +1     
  Misses        567      567              
  Partials       91       91

Impacted Files	Coverage Δ
src/services/reportsService.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf20ec...7634a9b. Read the comment docs.

[bclarhk]

It would be nice (future enhancement) to change the download names to match the name of the scan(s) and appended 'merged' to merged files too.

[bclarhk]

👍