From 5ad492cfcdff5b2f1bc10dea817d8917c4bb75e4 Mon Sep 17 00:00:00 2001 From: Sergey Skovorodkin Date: Fri, 30 Aug 2024 12:32:05 +0000 Subject: [PATCH] ydb_topic writer: remove obsolete fields --- .../sdk/cpp/client/ydb_topic/impl/write_session_impl.cpp | 5 ----- .../sdk/cpp/client/ydb_topic/impl/write_session_impl.h | 8 +------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/ydb/public/sdk/cpp/client/ydb_topic/impl/write_session_impl.cpp b/ydb/public/sdk/cpp/client/ydb_topic/impl/write_session_impl.cpp index f883361fb8e7..929c00cb1e1a 100644 --- a/ydb/public/sdk/cpp/client/ydb_topic/impl/write_session_impl.cpp +++ b/ydb/public/sdk/cpp/client/ydb_topic/impl/write_session_impl.cpp @@ -404,10 +404,6 @@ void TWriteSessionImpl::InitWriter() { // No Lock, very initial start - no race ThrowFatalError("ProducerId != MessageGroupId scenario is currently not supported"); } CompressionExecutor = Settings.CompressionExecutor_; - IExecutor::TPtr executor; - executor = CreateSyncExecutor(); - executor->Start(); - Executor = std::move(executor); Settings.CompressionExecutor_->Start(); Settings.EventHandlers_.HandlersExecutor_->Start(); @@ -1206,7 +1202,6 @@ void TWriteSessionImpl::ResetForRetryImpl() { } if (!OriginalMessagesToSend.empty() && OriginalMessagesToSend.front().Id < minId) minId = OriginalMessagesToSend.front().Id; - MinUnsentId = minId; Y_ABORT_UNLESS(PackedMessagesToSend.size() == totalPackedMessages); Y_ABORT_UNLESS(OriginalMessagesToSend.size() == totalOriginalMessages); } diff --git a/ydb/public/sdk/cpp/client/ydb_topic/impl/write_session_impl.h b/ydb/public/sdk/cpp/client/ydb_topic/impl/write_session_impl.h index 1f3abe9ba96a..74e47b15af48 100644 --- a/ydb/public/sdk/cpp/client/ydb_topic/impl/write_session_impl.h +++ b/ydb/public/sdk/cpp/client/ydb_topic/impl/write_session_impl.h @@ -410,10 +410,7 @@ class TWriteSessionImpl : public TContinuationTokenIssuer, TWriteSessionSettings Settings; std::shared_ptr Client; std::shared_ptr Connections; - TString TargetCluster; - TString InitialCluster; - TString CurrentCluster; - TString PreferredClusterByCDS; + std::shared_ptr ConnectionFactory; TDbDriverStatePtr DbDriverState; TStringType PrevToken; @@ -433,7 +430,6 @@ class TWriteSessionImpl : public TContinuationTokenIssuer, std::shared_ptr ServerMessage; // Server message to write server response to. TString SessionId; - IExecutor::TPtr Executor; IExecutor::TPtr CompressionExecutor; size_t MemoryUsage = 0; //!< Estimated amount of memory used bool FirstTokenSent = false; @@ -456,10 +452,8 @@ class TWriteSessionImpl : public TContinuationTokenIssuer, ui32 PartitionId = 0; TPartitionLocation PreferredPartitionLocation = {}; ui64 NextId = 0; - ui64 MinUnsentId = 1; TMaybe InitSeqNo; TMaybe AutoSeqNoMode; - bool ValidateSeqNoMode = false; NThreading::TPromise InitSeqNoPromise; bool InitSeqNoSetDone = false;