Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document workflow fails when RoxygenNote: is out of date in the DESCRIPTION #616

Closed
Moohan opened this issue Sep 6, 2022 · 3 comments
Closed
Labels
bug an unexpected problem or unintended behavior

Comments

@Moohan
Copy link

Moohan commented Sep 6, 2022

Describe the bug
Document workflow can modify the DESCRIPTION file (by updating the Roxygen version note) but it won't commit the change. This leads to a build error when there is nothing else to commit.

To Reproduce
failed build

Run the action on a package which is 'properly' documented but has an older roxygen version in the DESCRIPTION

Expected behaviour
Commit the change to the DESCRIPTION. Or do nothing but don't fail if only the DESCRIPTION is to be changed.

@Moohan Moohan added the bug an unexpected problem or unintended behavior label Sep 6, 2022
@dpprdan
Copy link
Contributor

dpprdan commented Apr 4, 2023

I think this is fixed now due to the changes in #694. @Moohan can you please try those out and report back?

@gaborcsardi
Copy link
Member

I assume that this is fixed now. Thanks for the PR!

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants