Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style does not commit changes made to .R files in tests/ #617

Closed
Moohan opened this issue Sep 6, 2022 · 3 comments
Closed

style does not commit changes made to .R files in tests/ #617

Moohan opened this issue Sep 6, 2022 · 3 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@Moohan
Copy link

Moohan commented Sep 6, 2022

Describe the bug
The style workflow does not commit any styled changes made to R scripts in the tests/ folder (even though styler is run against these with styler::style_pkg()). This results in an error when the tests are the only files styled, as styler makes the changes but then nothing is committed.

To Reproduce
failed build

Expected behavior
Style changes to the test scripts should also be committed.

@dpprdan
Copy link
Contributor

dpprdan commented Apr 4, 2023

This ought to be fixed with the changes in #693

#693 addresses both issues. 1. commit files changes outside the R/ folder and 2. not error when nothing (style-related) has changed.

@gaborcsardi
Copy link
Member

I assume that this is fixed now. Thanks for the PR!

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants