Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{pak} should advertise the use of binaries when using RSPM binaries? #408

Closed
pat-s opened this issue Aug 28, 2022 · 1 comment
Closed

{pak} should advertise the use of binaries when using RSPM binaries? #408

pat-s opened this issue Aug 28, 2022 · 1 comment

Comments

@pat-s
Copy link

pat-s commented Aug 28, 2022

When installing RSPM binaries on Linux, it looks like as if {pak} might download the source of the package due to the line

Got brew 1.0-7 (source) (75.66 kB)

This is not true as the RSPM binary is downloaded and installed (which can be verified by installing a package like {stringi} which would otherwise cause a long install time when installed from source). However, this line above causes confusion and maybe {pak} could output something like

Got brew 1.0-7 (binary) (75.66 kB)

instead?

Maybe this is even not caused by {pak} but because RSPM puts the binary tarballs below src/ instead of binary/?
Maybe this is because CRAN builds no binary pkgs and therefore on Linux there is no binary/ dir?
https://packagemanager.rstudio.com/client/#/repos/1/packages/brew

BINARY FILE FOR [UBUNTU 20.04 (FOCAL)](https://packagemanager.rstudio.com/client/) AND [R 4.2](https://packagemanager.rstudio.com/client/)
https://packagemanager.rstudio.com/all/__linux__/focal/latest/src/contrib/brew_1.0-7.tar.gz?r_version=4.2
pak::pkg_install("brew")
 
→ Will install 1 package.Will download 1 CRAN package (55.52 kB).
+ brew   1.0-7 [bld][dl] (55.52 kB)
ℹ Getting 1 pkg (55.52 kB)
✓ Got brew 1.0-7 (source) (75.66 kB)                               
✓ Downloaded 1 package (75.66 kB)in 1.4sBuilding brew 1.0-7Built brew 1.0-7 (490ms)                                  
✓ Installed brew 1.0-7  (36ms)                                
✓ 1 pkg: added 1, dld 1 (75.66 kB) [2.8s] 

getOption("repos")
                                                                RSPM 
"https://packagemanager.rstudio.com/cran/__linux__/focal/2022-06-23"
@gaborcsardi
Copy link
Member

Yes, this is part of r-lib/pkgdepends#186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants